[KyleFromNVIDIA]

Bashlex, the underlying Python library that this check uses to parse bash scripts, does not support mathematical expressions, and so we have never been able to use it in RAPIDS. Most scripts use other commands anyway, so this check wouldn't catch anything. Remove it.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: rapidsai/pre-commit-hooks/.coderabbit.yaml
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 57318c4d-8d47-48bd-a4d3-955810658e11

📥 Commits

Reviewing files that changed from the base of the PR and between 2c7d175 and b863359.

📒 Files selected for processing (8)

• .pre-commit-hooks.yaml
• pyproject.toml
• src/rapids_pre_commit_hooks/shell/__init__.py
• src/rapids_pre_commit_hooks/shell/verify_conda_yes.py
• tests/examples/verify-conda-yes/fail/main/test.sh
• tests/examples/verify-conda-yes/pass/main/test.sh
• tests/rapids_pre_commit_hooks/test_shell.py
• thirdparty/LICENSE/LICENSE.bashlex

💤 Files with no reviewable changes (8)

• pyproject.toml
• tests/examples/verify-conda-yes/fail/main/test.sh
• thirdparty/LICENSE/LICENSE.bashlex
• .pre-commit-hooks.yaml
• src/rapids_pre_commit_hooks/shell/verify_conda_yes.py
• tests/examples/verify-conda-yes/pass/main/test.sh
• tests/rapids_pre_commit_hooks/test_shell.py
• src/rapids_pre_commit_hooks/shell/init.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

---

📝 Summary

Summary by CodeRabbit

• Other Changes
  • Removed the shell check for conda commands that lack -y or --yes, along with its automatic fix suggestion.
  • Removed the related pre-commit hook and its test coverage.

Walkthrough

The pull request removes the verify-conda-yes hook, its shell parsing and linting implementation, its project script entry, and its tests and examples.

Changes

Conda hook removal

Layer / File(s)	Summary
Remove checker and supporting hook wiring .pre-commit-hooks.yaml, pyproject.toml, src/rapids_pre_commit_hooks/shell/*, tests/examples/verify-conda-yes/*, tests/rapids_pre_commit_hooks/test_shell.py, thirdparty/LICENSE/LICENSE.bashlex	The verify-conda-yes hook configuration and project script entry are removed. The shell parsing and linting implementation, its tests and examples, and the bashlex license file are also removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b8633

The removed check has no remaining registration or caller. No actionable merge-blocking issue is established.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely identifies the main change: removal of the verify-conda-yes check.
Description check	✅ Passed	The description explains why the verify-conda-yes check is removed and directly matches the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

[jameslamb]

Yeah I'm supportive

[KyleFromNVIDIA]

/merge