Skip to content

Refactor TestLinter to use parse_named_spans() #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
Oct 6, 2026
Merged

Refactor TestLinter to use parse_named_spans() #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 31 additions & 17 deletions tests/rapids_pre_commit_hooks/test_lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,33 +192,47 @@ def test_line_for_pos(

class TestLinter:
def test_fix(self):
linter = Linter("test.txt", "Hello world!", "test")
content, spans = parse_named_spans(
"""\
> Hello world!
: ^no_fix
: ^punctuation
: ~~~~~hello
: ~shout
: ~~~~~world
: ^noop
"""
)
linter = Linter("test.txt", content, "test")
assert linter.fix() == "Hello world!"

linter.add_warning((0, 0), "no fix")
linter.add_warning(spans["no_fix"], "no fix")
assert linter.fix() == "Hello world!"

linter.add_warning((5, 5), "use punctuation").add_replacement(
(5, 5), ","
)
linter.add_warning((0, 5), "say good bye instead").add_replacement(
(0, 5), "Good bye"
)
linter.add_warning((11, 12), "don't shout").add_replacement(
(11, 12), ""
)
linter.add_warning((6, 11), "no-op replacement").add_replacement(
(11, 11), ""
linter.add_warning(
spans["punctuation"], "use punctuation"
).add_replacement(spans["punctuation"], ",")
linter.add_warning(
spans["hello"], "say good bye instead"
).add_replacement(spans["hello"], "Good bye")
linter.add_warning(spans["shout"], "don't shout").add_replacement(
spans["shout"], ""
)
linter.add_warning(
spans["world"], "no-op replacement"
).add_replacement(spans["noop"], "")
assert linter.fix() == "Good bye, world"

linter.add_warning((11, 12), "don't shout").add_replacement(
(11, 12), "."
linter.add_warning(spans["shout"], "don't shout").add_replacement(
spans["shout"], "."
)
with pytest.raises(
OverlappingReplacementsError,
match=r"^Replacement\(span=\(11, 12\), newtext=''\) overlaps with "
+ r"Replacement\(span=\(11, 12\), newtext='\.'\)$",
match=r"^Replacement\(span="
rf"\({spans['shout'][0]}, {spans['shout'][1]}\),"
r" newtext=''\) overlaps with "
rf"Replacement\(span=\({spans['shout'][0]}, {spans['shout'][1]}\),"
r" newtext='\.'\)$",
):
linter.fix()

Expand Down
Loading