Skip to content

Declare libgomp as a libnvforest and libnvforest-tests host dependency - #257

Merged
chyunsu3 merged 1 commit into
rapidsai:mainfrom
chyunsu3:libnvforest-libgomp
Oct 20, 2026
Merged

chyunsu3 merged 1 commit into
rapidsai:mainfrom
chyunsu3:libnvforest-libgomp

Conversation

@chyunsu3

Copy link
Copy Markdown
Contributor

libnvforest.so links libgomp.so.1 (OpenMP is enabled by default). With the newer rattler-build (>=0.77), the SONAME ownership check reports it as overlinked because libgomp is declared only under run, not host, for the libnvforest and libnvforest-tests outputs.

Same fix as NVIDIA/cuml#8803, see that PR and linked issue for more details.

@chyunsu3
chyunsu3 requested a review from a team as a code owner October 20, 2026 22:52
@chyunsu3
chyunsu3 requested a review from bdice October 20, 2026 22:52
@github-actions github-actions Bot added the conda Relates to conda packaging label Oct 20, 2026
@chyunsu3 chyunsu3 added bug Something isn't working non-breaking Introduces a non-breaking change labels Oct 20, 2026
@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: rapidsai/nvforest/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: c30f2b24-d7e8-4f8a-80b6-65510d093f19
📥 Commits

Reviewing files that changed from the base of the PR and between bd36a88 and e20a9cf.

📒 Files selected for processing: 1
  • conda/recipes/libnvforest/recipe.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated package requirements to improve compatibility and reliability for libnvforest and its test package builds.

The recipe adds libgomp >=${{ c_compiler_version }} to the host requirements for both libnvforest and libnvforest-tests.

Changes: Host requirements

Layer / File(s) Summary
Add libgomp host requirements
conda/recipes/libnvforest/recipe.yaml
Both package definitions add libgomp constrained to at least the configured C compiler version.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to e20a9

The dependency declaration change is limited and presents no identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly describes the main change: adding libgomp as a host dependency for libnvforest and libnvforest-tests.
Description check Passed The description explains the libgomp linking issue, the rattler-build overlinking check, and the scope of the fix.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@chyunsu3
chyunsu3 merged commit d9eb888 into rapidsai:main Oct 20, 2026
54 checks passed
@chyunsu3
chyunsu3 deleted the libnvforest-libgomp branch October 20, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working conda Relates to conda packaging non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants