Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe PR adds the RMM CUDA stream view header and changes GPU handle stream extraction from ChangesGPU stream handling
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The CUDA stream API update and required header inclusion are consistent with the stated changes. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
170b664 to
a6f8a03
Compare
cuda::stream_ref
|
@bdice @RAMitchell Can I get a review? |
| #include <nvforest/detail/owning_buffer/base.hpp> | ||
| #include <nvforest/device_type.hpp> | ||
|
|
||
| #include <rmm/cuda_stream_view.hpp> |
There was a problem hiding this comment.
I reopened #209 and retargeted it to release/26.10.
|
Superseded by #209 |
Update nvForest according to rapidsai/rmm#2372 and NVIDIA/raft#3129. Both changes landed in the 26.10 branch, so this PR also targets 26.10.
rmm::cuda_stream_viewis now deprecated; we need to include<rmm/cuda_stream_view.hpp>explicitly now.get_next_usable_stream()now returnscuda::stream_refinstead ofrmm::cuda_stream_view