Repository navigation
ci: use proxy cache for pypi.anaconda.org, remove pip indices from dependencies.yaml - #552
Merged
Merged
Conversation
jameslamb
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Member
Author
|
/ok to test 7e1d343 |
This was referenced Oct 5, 2026
jameslamb
commented
Oct 5, 2026
| # * echo to expand wildcard before adding `[extra]` requires for pip | ||
| # * '--extra-index-url pypi.nvidia.com' can be removed when 'cugraph' and | ||
| # its dependencies are available from pypi.org | ||
| # |
Member
Author
There was a problem hiding this comment.
This comment was not moved when the arguments it describes were moved up into this PIP_INSTALL_ARGS array. Cleaning that up while I'm here, but it's unrelated to this PR's other goals.
jameslamb
commented
Oct 5, 2026
Comment on lines
-592
to
-596
| - output_types: requirements | ||
| packages: | ||
| # pip recognizes the index as a global option for the requirements.txt file | ||
| - --extra-index-url=https://pypi.nvidia.com | ||
| - --extra-index-url=https://pypi.anaconda.org/rapidsai-wheels-nightly/simple |
Member
Author
There was a problem hiding this comment.
In general we shouldn't need any --extra-index-url entries like this for projects built within this same repo.
Any CI jobs should be getting the just-built-in-CI packages and devcontainers should be building everything from source.
jameslamb
commented
Oct 5, 2026
jameslamb
changed the title
jameslamb
marked this pull request as ready for review
October 5, 2026 19:36
jameslamb
added a commit
to rapidsai/devcontainers
that referenced
this pull request
Oct 6, 2026
In rapidsai/build-planning#338, I'm working on enabling NVIDIA's self-hosted proxy cache for `pypi.anaconda.org` in CI. To do that, we want to pass an extra index URL to `pip` like `https://pypi-anaconda-cache.local.gha-runners.nvidia.com/rapidsai-wheels-nightly/simple/` and avoid ever passing `https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/`. RAPIDS devcontainers depend on projects' `dependencies.yaml` files to supply `--extra-index-url` values needed to construct the environment. e.g. cuML has something like this: ```yaml depends_on_cudf: common: - output_types: requirements packages: - --extra-index-url=https://pypi.anaconda.org/rapidsai-wheels-nightly/simple specific: - output_types: [requirements, pyproject] matrices: - matrix: cuda: "12.*" cuda_suffixed: "true" packages: - cudf-cu12==26.12.*,>=0.0.0a0 - matrix: cuda: "13.*" cuda_suffixed: "true" packages: - cudf-cu13==26.12.*,>=0.0.0a0 - matrix: cuda_suffixed: "false" packages: - *cudf_unsuffixed ``` ([build link](https://github.com/NVIDIA/cuml/blob/ac7dc8f3a5a222c3f8d0d1460a4f95bae99c1253/dependencies.yaml#L794)) Which would write something like this to the `requirements.txt` generated by tools in devcontainers: ```text --extra-index-url=https://pypi.anaconda.org/rapidsai-wheels-nightly/simple cudf-cu13==26.12.*,>=0.0.0a0 ``` So in RAPIDS CI, we have to find someway to either convert those to the proxy cache URL or avoid generating them at all. I'm proposing that we *remove* those types of entries from `dependencies.yaml` (example: rapidsai/cugraph-gnn#552) across RAPIDS, and instead just pass the nightly index unconditionally in devcontainers' environments. ## Alternatives Instead of this, I also considered modifying projects' `dependencies.yaml` files like this: ```diff diff --git a/dependencies.yaml b/dependencies.yaml index 441f83f5b1..609c4c00a6 100644 --- a/dependencies.yaml +++ b/dependencies.yaml @@ -1319,11 +1319,16 @@ dependencies: - output_types: conda packages: - &libcudf_unsuffixed libcudf==26.12.*,>=0.0.0a0 - - output_types: [requirements, constraints] - packages: - # pip recognizes the index as a global option for the requirements.txt file - - --extra-index-url=https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/ specific: + - output_types: [requirements, constraints] + matrices: + - matrix: + include_pip_indices: false + packages: + - matrix: + packages: + # pip recognizes the index as a global option for the requirements.txt file + - --extra-index-url=https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/ - output_types: [requirements, constraints, pyproject] matrices: - matrix: ``` And passing `include_pip_indices=false` at all the call sites in RAPIDS CI. But that seems more complex and error-prone than excluding it from `dependencies.yaml` altogether.
jameslamb
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
KyleFromNVIDIA
approved these changes
Oct 6, 2026
Member
Author
|
/merge |
Contributor
|
Failed to merge PR using squash strategy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#338
Enables NVIDIA's self-hosted pull-through proxy cache for
pypi.anaconda.org. See the linked issue for benefits of doing that.--extra-index-urlpointing at nightly index fromdependencies.yaml(already set globally in CI images)PIP_EXTRA_INDEX_URLexplicitly inpipdevcontainers (so it doesn't need to rely on values fromdependencies.yaml)Notes for Reviewers
How I tested this
Saw
pip-based CI jobs emit lines like this frompip install(build link)