Skip to content

fix(vm-agent): bind prompt-cancel grace watchdog to the cancelled attempt #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simple-agent-manager merged 6 commits into from
Sep 29, 2026
Merged

fix(vm-agent): bind prompt-cancel grace watchdog to the cancelled attempt #2180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0921ebd
task: add bind-prompt-cancel-watchdog-to-attempt
raphaeltm Sep 29, 2026
1bafb88
refactor(vm-agent): split session_host.go below the file-size ceiling
raphaeltm Sep 29, 2026
c9d4f55
fix(vm-agent): bind the prompt-cancel grace watchdog to the cancelled…
raphaeltm Sep 29, 2026
a661753
fix(vm-agent): prove stuck-cancel recovery end to end; defer to in-fl…
raphaeltm Sep 29, 2026
5a169d7
task: file flaky harness activity coalesce test
raphaeltm Sep 29, 2026
6d47303
task: record staging evidence and archive bind-prompt-cancel-watchdog…
raphaeltm Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/skills/env-reference/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,7 @@ Generated deployments validate and pass these values through cloud-init to newly
- `ACP_PONG_TIMEOUT` — WebSocket pong deadline after ping (default: 10s)
- `ACP_PROMPT_TIMEOUT` — Max ACP prompt runtime for workspace sessions; 0 = no timeout (default: 0)
- `ACP_TASK_PROMPT_TIMEOUT` — Max ACP prompt runtime for task-driven sessions (default: 8h)
- `ACP_PROMPT_CANCEL_GRACE_PERIOD` — Grace wait after cancel before force-stop (default: 5s)
- `ACP_PROMPT_CANCEL_GRACE_PERIOD` — Grace wait for the cancelled prompt to settle before it is finished as `cancelled` and the agent is restarted (default: 5s). Bound to the cancelled prompt; never affects a later prompt
- `ACP_PROMPT_RETRY_MAX_RETRIES` — Max transient provider prompt retries after the initial attempt (default: 2)
- `ACP_PROMPT_RETRY_INITIAL_BACKOFF` — Initial backoff before retrying transient provider prompt errors (default: 15s)
- `ACP_PROMPT_RETRY_MAX_BACKOFF` — Max exponential backoff for transient provider prompt retries (default: 2m)
Expand Down
3 changes: 2 additions & 1 deletion packages/vm-agent/internal/acp/gateway.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,8 @@ type GatewayConfig struct {
PongTimeout time.Duration
// PromptTimeout bounds how long a prompt can run before force-stop fallback.
PromptTimeout time.Duration
// PromptCancelGracePeriod waits after cancel before force-stopping unresponsive prompt.
// PromptCancelGracePeriod waits after cancel for the cancelled prompt to
// settle before finishing it as cancelled and restarting the agent.
PromptCancelGracePeriod time.Duration
// PromptRetryMaxRetries bounds transient provider prompt retries after the initial attempt.
PromptRetryMaxRetries int
Expand Down
Loading
Loading