Skip to content

Design: add animated moon asset for session sleep progress - #2062

Draft
raphaeltm wants to merge 1 commit into
mainfrom
design/session-sleep-progress-moon
Draft

raphaeltm wants to merge 1 commit into
mainfrom
design/session-sleep-progress-moon

Conversation

@raphaeltm

Copy link
Copy Markdown
Owner

Summary

This is intentionally a draft, design-only PR.

It adds an animated SVG that can be used as the visual treatment while a session is in the process of being put to sleep.

There is no implementation wiring in this PR. It does not change session state handling, API behavior, lifecycle logic, or the existing UI flow. The intent is simply to land the candidate asset so the eventual implementation has a concrete animation to work from.

Asset

apps/web/src/assets/session-sleep-progress.svg

The animation:

  • keeps the same outlined moon language as the existing sleep icon
  • cycles slowly through a realistic waxing / waning progression
  • reaches a true circular full moon
  • avoids an abrupt side-switch at new moon by fading through the near-zero phase
  • is white on transparent so it can sit inside the existing blue sleep action treatment
  • uses native SVG animation and has a prefers-reduced-motion fallback

Intended use

When the user triggers Sleep session, this could replace the static moon icon while the sleep operation is still in progress, then return to the normal state once the session has actually reached the sleeping state.

The exact integration point still needs to be implemented. In particular, the final UI should derive the in-progress state from the actual session sleep lifecycle rather than from a purely local loading timer.

Not included

  • wiring the asset into the current sleep button
  • determining / exposing the authoritative frontend sleeping or sleep-in-progress state
  • error / retry UI
  • tests for the future integration

This PR is mainly a handoff/reference for that follow-up work.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 6900a500-6e26-41fe-b4c4-5e19c86ab67d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@simple-agent-manager

Copy link
Copy Markdown
Contributor

needs-human-review: unspecified product/UX-visible semantics for adopting this draft sleep-progress asset.

@simple-agent-manager simple-agent-manager Bot added the needs-human-review Agent could not complete all review gates — human must approve before merge label Sep 13, 2026
@simple-agent-manager

Copy link
Copy Markdown
Contributor

needs-human-review: unspecified product/UX-visible semantics for the sleep-progress animation asset and integration behavior.

@simple-agent-manager

Copy link
Copy Markdown
Contributor

PR shepherd reason: unspecified product/UX-visible semantics — draft sleep-progress animation asset needs human visual/product direction before merge.

@simple-agent-manager

Copy link
Copy Markdown
Contributor

Weekly queue reconciliation — 2026-09-23. Park decision: keep open, needs one product call.

Status: draft, 12 days old, 1 file, 93 commits behind main. Two prior nudges (09-16, 09-21) said the same thing and produced no movement, so here is the specific decision that is blocking it rather than another reminder.

This PR adds apps/web/src/assets/session-sleep-progress.svg and deliberately wires nothing. It cannot merge or be rejected on engineering grounds — it is waiting on one answer from @raphaeltm:

Should a session that is being put to sleep show an animated moon at all, and if so, where — in the session header, the lifecycle button, or the chat composer area?

Relevant since this PR was opened: policy a65b1778 now fixes the lifecycle semantics (working → Stop, awake idle → Sleep, sleeping → Archive), so "sleeping" is a first-class, reversible state with a defined UI slot. That makes the question answerable now in a way it wasn't on 09-11.

Being one unwired asset file, it will not rot — rebasing past 93 commits is trivial. Leaving it open and labeled needs-human-review is correct. No action needed from agents; this comment exists so the next weekly audit does not re-nudge it blindly.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-human-review Agent could not complete all review gates — human must approve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant