fix(matter): address #1246 review — log noise, fallback routing, test caplog level

[raman325]

Proposed change

Addresses Copilot's four review comments on #1246. All four were valid.

Comment #3393233004 — INFO log spam on affected locks

The success-on-fallback path logs at INFO every time async_set_user runs on a lock that consistently rejects the canonical tag. Since BaseLock calls async_set_user on every credential write, this can spam logs in normal operation for affected locks.

Fix: demote both UPDATE-path and CREATE-path success-on-fallback messages from `LOGGER.info` to `LOGGER.debug`. The diagnostic remains available when the user enables debug logging; the full-failure warning path is unchanged.

Comment #3393232929 — Fallback exception routing was narrow

CREATE fallback retry only catches MatterError. If the slot-only retry raises HomeAssistantError (disconnect/offline) or ServiceValidationError, it will currently bubble out as an unexpected exception type rather than being mapped to LockDisconnected/LockOperationFailed like the primary CREATE attempt. This can reintroduce the same "catchall suspend" behavior the MatterError mapping was meant to avoid.

Fix: mirror the primary CREATE attempt's typed routing on the fallback retry:

• `ServiceValidationError → LockOperationFailed`
• `HomeAssistantError → LockDisconnected`
• `MatterError → LockOperationFailed` (after both attempts)

Two new regression tests pin these mappings:

• `test_set_user_create_routes_validation_error_during_fallback`
• `test_set_user_create_routes_disconnect_during_fallback`

Comments #3393232961 + #3393232981 — Tests didn't set caplog level

This test asserts on INFO-level log text but doesn't set caplog's capture level. Make the test self-contained by explicitly enabling INFO logging for the provider module before exercising the behavior.

Fix: both fallback-success tests now call `caplog.set_level(logging.DEBUG, logger=_PROVIDER_MODULE)` before exercising the behavior. (DEBUG, not INFO, because of fix #1 above.) The tests are now self-contained and don't depend on the global pytest logging config.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (which adds functionality)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Test plan

• Full suite passes locally (1162/1162; +2 new tests for the fallback-routing fix)
• Existing fallback-success tests still pass with the explicit `caplog.set_level` call
• DEBUG log path verified locally — the success-on-fallback message is only emitted at DEBUG, so locks that consistently need the fallback no longer flood the log

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR follows up on review feedback from #1246 by reducing Matter provider log noise, ensuring fallback retries route exceptions consistently, and making the related tests self-contained with explicit caplog configuration.

Changes:

• Demotes “success-on-fallback” messages from INFO to DEBUG to avoid repeated log spam on locks that always require the slot-only fallback.
• Expands CREATE fallback exception routing to mirror the primary attempt (ServiceValidationError → LockOperationFailed, HomeAssistantError → LockDisconnected).
• Updates/adds tests to explicitly set caplog level (DEBUG) and adds regression tests for fallback exception routing.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
custom_components/lock_code_manager/providers/matter.py	Demotes fallback-success logs to DEBUG and adds typed exception routing for CREATE fallback retries.
tests/providers/matter/test_provider.py	Makes fallback-success log assertions robust via caplog.set_level(...) and adds regression tests for fallback exception mapping.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.99%. Comparing base (0ae0aec) to head (a715219).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1248   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files          53       53           
  Lines        6181     6185    +4     
  Branches      461      461           
=======================================
+ Hits         5995     5999    +4     
  Misses        186      186           

Flag	Coverage Δ
python	97.53% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...m_components/lock_code_manager/providers/matter.py	99.38% <100.00%> (+<0.01%)	⬆️

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.