chore: de-submodule to soldeer (rain.interpreter -> rainlang, pyth SDK)#23
Conversation
Replace lib/forge-std, lib/rain.interpreter, lib/pyth-crosschain submodules with explicit soldeer deps. rain.interpreter -> rainlang; pyth SDK -> @pythnetwork-pyth-sdk-solidity. - full flattened interpreter dep tree at pinned versions; versioned imports - reconcile rainlang rename (BaseRainterpreter*NPE2 -> BaseRainlang*), interface path drift, and LibIntOrAString.fromString2 -> fromStringV3 - recompute the hardcoded feed-symbol IntOrAString constants for the V3 encoding (the parser now encodes string literals with fromStringV3, so the V2 keys no longer matched -> UnsupportedFeedSymbol) - regenerate meta/pointers; CI -> reusable rainix-sol; gitignore dependencies/ - forge test: 15/15 (excluding RPC-fork tests needing CI secrets) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 29 minutes and 17 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (29)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed a4432e4: APPROVE — de-submodule to soldeer (rainlang 0.1.2 + pyth SDK 4.3.1), CI on reusable rainix-sol + copy-artifacts, PRIVATE_KEY deploy. All 47 V3 feed-symbol constants encoding-pinned and routed through getPriceFeedId; full test suite green. |
Replaces the forge-std / rain.interpreter / pyth-crosschain submodules with soldeer deps (
rainlang,@pythnetwork-pyth-sdk-solidity). Versioned imports, rainlang rename + interface path drift reconciled,fromString2->fromStringV3, and the hardcoded feed-symbol IntOrAString constants recomputed for the V3 encoding (the V2 keys no longer matched the parser's V3 literal encoding). forge test 15/15 (ex. RPC-fork tests needing CI secrets).🤖 Generated with Claude Code