Skip to content

chore: de-submodule to soldeer (rain.interpreter -> rainlang, pyth SDK)#23

Merged
thedavidmeister merged 4 commits into
mainfrom
2026-06-03-desubmodule-soldeer
Jun 4, 2026
Merged

chore: de-submodule to soldeer (rain.interpreter -> rainlang, pyth SDK)#23
thedavidmeister merged 4 commits into
mainfrom
2026-06-03-desubmodule-soldeer

Conversation

@thedavidmeister
Copy link
Copy Markdown
Contributor

Replaces the forge-std / rain.interpreter / pyth-crosschain submodules with soldeer deps (rainlang, @pythnetwork-pyth-sdk-solidity). Versioned imports, rainlang rename + interface path drift reconciled, fromString2->fromStringV3, and the hardcoded feed-symbol IntOrAString constants recomputed for the V3 encoding (the V2 keys no longer matched the parser's V3 literal encoding). forge test 15/15 (ex. RPC-fork tests needing CI secrets).

🤖 Generated with Claude Code

Replace lib/forge-std, lib/rain.interpreter, lib/pyth-crosschain submodules with
explicit soldeer deps. rain.interpreter -> rainlang; pyth SDK ->
@pythnetwork-pyth-sdk-solidity.

- full flattened interpreter dep tree at pinned versions; versioned imports
- reconcile rainlang rename (BaseRainterpreter*NPE2 -> BaseRainlang*), interface
  path drift, and LibIntOrAString.fromString2 -> fromStringV3
- recompute the hardcoded feed-symbol IntOrAString constants for the V3 encoding
  (the parser now encodes string literals with fromStringV3, so the V2 keys no
  longer matched -> UnsupportedFeedSymbol)
- regenerate meta/pointers; CI -> reusable rainix-sol; gitignore dependencies/
- forge test: 15/15 (excluding RPC-fork tests needing CI secrets)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Warning

Review limit reached

@thedavidmeister, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 29 minutes and 17 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: cfc1e56c-ed7c-445e-9f5e-9fa296370bde

📥 Commits

Reviewing files that changed from the base of the PR and between 7db8604 and a4432e4.

⛔ Files ignored due to path filters (3)
  • foundry.lock is excluded by !**/*.lock
  • soldeer.lock is excluded by !**/*.lock
  • src/generated/PythWords.pointers.sol is excluded by !**/generated/**
📒 Files selected for processing (29)
  • .github/workflows/git-clean.yaml
  • .github/workflows/manual-sol-artifacts.yaml
  • .github/workflows/rainix-sol.yaml
  • .github/workflows/rainix.yml
  • .gitignore
  • .gitmodules
  • REUSE.toml
  • foundry.toml
  • lib/forge-std
  • lib/pyth-crosschain
  • lib/rain.interpreter
  • remappings.txt
  • script/BuildAuthoringMeta.sol
  • script/BuildPointers.sol
  • script/Deploy.sol
  • script/build.sh
  • slither.config.json
  • src/abstract/PythExtern.sol
  • src/abstract/PythSubParser.sol
  • src/concrete/PythWords.sol
  • src/lib/op/LibOpPythPrice.sol
  • src/lib/parse/LibPythSubParser.sol
  • src/lib/pyth/LibPyth.sol
  • test/src/concrete/PythWords.pythPrice.t.sol
  • test/src/lib/op/LibOpPythPrice.t.sol
  • test/src/lib/pyth/LibPyth.constants.t.sol
  • test/src/lib/pyth/LibPyth.getPriceFeedContract.t.sol
  • test/src/lib/pyth/LibPyth.getPriceFeedId.t.sol
  • test/src/lib/pyth/LibPyth.getPriceNoOlderThan.t.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-06-03-desubmodule-soldeer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister
Copy link
Copy Markdown
Contributor Author

Reviewed a4432e4: APPROVE — de-submodule to soldeer (rainlang 0.1.2 + pyth SDK 4.3.1), CI on reusable rainix-sol + copy-artifacts, PRIVATE_KEY deploy. All 47 V3 feed-symbol constants encoding-pinned and routed through getPriceFeedId; full test suite green.

@thedavidmeister thedavidmeister merged commit 97b3b4c into main Jun 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant