feat(social): show ladder position in /rank and /leaderboard - #29
Merged
Conversation
Add rank_position(db, guild_id, level, xp): count members strictly above and +1. /rank now shows "#N"; /leaderboard appends the caller's own rank when they're outside the top 10. Unit-tested (ties broken by xp, guild isolation, edges). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leveling polish:
/ranknow shows your #position on the server ladder (not just level/XP)./leaderboardappends your rank when you're outside the top 10 (… (you)).New
rank_position(db, guild_id, level, xp)counts members strictly above(level, xp)and adds 1 — ties broken by XP, matching the leaderboard ordering.Testing
test_rank_position.py: ordering, XP tie-break, new-member-last, above-all, guild isolation.ruff+ruff format+pytest(21 tests) green.🤖 Generated with Claude Code