Repository navigation
Drop whitespace-padded terminal border lines - #8
Merged
Merged
Conversation
This was referenced Aug 24, 2026
serrebidev
pushed a commit
to serrebidev/virtualReview
that referenced
this pull request
Sep 23, 2026
- Restore Virtual Review in Windows Terminal tabs and panes by capturing straight from the focused TermControl (fix-terminal-review) - Add a Virtual Revision settings panel with a toggle for the UWP review alert beeps (settings-beep-toggle) - Strip terminal padding and decorative box-drawing borders from reviewed text, treating whitespace inside border rows as decorative (clean-terminal-text, ragb#8) - Add NVDA+Alt+W as the documented shortcut while keeping NVDA+Control+W, avoiding the NVDA 2026.2 magnifier conflict (ragb#9) - Update all localized readmes with the new shortcut - Bump version to 2026.09.23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treat whitespace between box-drawing characters as decorative when cleaning Windows Terminal text.
The existing predicate strips leading and trailing whitespace, then checks every remaining character against the Unicode Box Drawing block. A row such as │ │ therefore survives because its internal spaces fail the range check, even though the row contains no content. Ignoring whitespace during that check makes the implementation match its documented intent.
Verification
This follows up the terminal cleanup ported in #5.