Skip to content

arm64: dts: rockchip: cm3j-rpi-cm4: use emc2305,*#546

Open
LZhaoM wants to merge 1 commit into
radxa:linux-6.1-stan-rkr4.1from
LZhaoM:cm3j-cm4-io-emc2301
Open

arm64: dts: rockchip: cm3j-rpi-cm4: use emc2305,*#546
LZhaoM wants to merge 1 commit into
radxa:linux-6.1-stan-rkr4.1from
LZhaoM:cm3j-cm4-io-emc2301

Conversation

@LZhaoM
Copy link
Copy Markdown

@LZhaoM LZhaoM commented Apr 28, 2026

arm64: dts: rockchip: cm3j-rpi-cm4: use emc2305,*

The microchip,emc2301 driver accepts the following properties[0]:
emc2305,cooling-levels
emc2305,pwm-max
emc2305,pwm-min
emc2305,pwm-channel

Because `of_property_read_u8`[0] is used, the 8 bits type needs to be
explicitly stated.

[0]: https://github.com/radxa/kernel/blob/e7976b5c9bd2f34e21d3cc871f54d67470e1ec42/drivers/hwmon/emc2305.c#L311-L333

Signed-off-by: Zhaoming Luo <luozhaoming@radxa.com>

The microchip,emc2301 driver accepts the following properties[0]:
emc2305,cooling-levels
emc2305,pwm-max
emc2305,pwm-min
emc2305,pwm-channel

Because `of_property_read_u8`[0] is used, the 8 bits type needs to be
explicitly stated.

[0]: https://github.com/radxa/kernel/blob/e7976b5c9bd2f34e21d3cc871f54d67470e1ec42/drivers/hwmon/emc2305.c#L311-L333

Signed-off-by: Zhaoming Luo <luozhaoming@radxa.com>
Copy link
Copy Markdown
Member

@RadxaYuntian RadxaYuntian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LZhaoM
Copy link
Copy Markdown
Author

LZhaoM commented May 15, 2026

因为上游的驱动很新,设备树的配置方法跟我们使用的驱动不太一样。我们的跟6.1.y0的emc2305驱动更相近,然后6.1.y里也没有emc2305 devicetree binding的配置资料,所以我是看着源码写的设备树。emc2305,pwm-channel设置成0就是所有channel都使用相同的thermal zone了1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants