Stop treating arm64 sub to a non-sp register as a stack reset ##arch - #26899
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On arm64 any
subwhose destination is not sp is treated as a stack reset, so aftersub x0, x0, 1the tracked depth drops to 0 and every later sp access in the block is read as a stack argument above the frame.str x0, [sp]writes the local at the bottom of the 0x20 frame; with this PR it isvar_20h @ sp+0x0andsub x0, x0, 1has no stackop.anop64no longer setsR_ANAL_STACK_RESETonsubwith a non-sp destination, matchingadd. Only instructions that write sp change the depth.arm.v35had the same reset on bothsubandadd; it goes too.aaaloses 3587 phantom stack args and gains none.The new case in
test/db/anal/arm64fails without the fix on both the variable and the stackop; itssub sp, sp, 0x20line keeps master'sincof 32. A second case checks thatarm.v35no longer reports a reset forsub x0, x0, 1oradd x0, x0, 1; it only runs on builds with v35 enabled.