Skip to content

Restore opcode descriptions with fixed SDB - #26896

Closed
trufae wants to merge 1 commit into
masterfrom
fix/sdb-opcode-regressions
Closed

trufae wants to merge 1 commit into
masterfrom
fix/sdb-opcode-regressions

Conversation

@trufae

@trufae trufae commented Oct 4, 2026

Copy link
Copy Markdown
Collaborator

The host SDB tool is built with USE_MMAN=0. SDB 2.5.6 reads database descriptors at EOF during repeated initialization, so sdb -t -C replaces populated opcode tables with empty arrays. This reproduces all 23 regressions in the reported TCC job, as well as the gperf and MIPS failures.

Pin SDB to 95f41f24bf8fc03a570424f17205884d44e6c59c in the Meson wrap and regenerated Make file. The upstream fixes and API-level regressions are in radareorg/sdb#330; merge that PR first. Add a direct aod regression covering x86 → MIPS → x86 switching and descriptions containing commas.

Validation:

  • Fresh root make -j2 builds before and after the fix.
  • The same 11 affected r2r files reproduce all 23 original failures plus the new test before the fix; afterwards: 587 passed, 3 known broken, 16 skipped, zero unexpected failures.
  • Independent db/cmd/describe run: all 3 tests pass.
  • Generated sdb.mk matches acr-wrap output; git diff --check passes.

Upstream SDB tests cover exact 64-bit decimal/hex persistence and generated string escaping, with full suites passing both with and without mmap.

@trufae trufae closed this Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants