Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host SDB tool is built with
USE_MMAN=0. SDB 2.5.6 reads database descriptors at EOF during repeated initialization, sosdb -t -Creplaces populated opcode tables with empty arrays. This reproduces all 23 regressions in the reported TCC job, as well as the gperf and MIPS failures.Pin SDB to
95f41f24bf8fc03a570424f17205884d44e6c59cin the Meson wrap and regenerated Make file. The upstream fixes and API-level regressions are in radareorg/sdb#330; merge that PR first. Add a directaodregression covering x86 → MIPS → x86 switching and descriptions containing commas.Validation:
make -j2builds before and after the fix.db/cmd/describerun: all 3 tests pass.sdb.mkmatchesacr-wrapoutput;git diff --checkpasses.Upstream SDB tests cover exact 64-bit decimal/hex persistence and generated string escaping, with full suites passing both with and without mmap.