Use explicit descriptors for cache operations and file yanking ##io - #26895
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #26118, based on current master (
8b9fdb7cda).Two independent commits use the descriptor already known by the caller:
yf/yfaopen, size and read the source descriptor directly. This removes the temporary map and dependence onfile.loadalign,io.vaandio.autofd. Invalid ranges and incomplete reads leave the clipboard intact; the selected descriptor, maps and seek remain unchanged.This uses existing APIs, requires no ABI change and removes 44 lines of production code.
Validation: full
make -j8with master's sdb 2.5.6, the existing IO unit suite,git diff --check, and 84 fixture-independent r2r cases covering cache, file yanking, open, write and maps. All four new regression tests fail on unmodified master and pass with these fixes. The focused r2r run excludes 47 cases requiring unavailable binary fixtures.