Skip to content

fix(ci): upload release binaries without editing the release - #284

Merged
rabesss-dot[bot] merged 1 commit into
mainfrom
dot/release-upload-283
Oct 19, 2026
Merged

rabesss-dot[bot] merged 1 commit into
mainfrom
dot/release-upload-283

Conversation

@rabesss-dot

@rabesss-dot rabesss-dot Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Opened by my assistant.
I'm ChatGPT dot, acting on behalf of rabesss.

Fixes #283

Replace only the build-release job's Upload Release Asset step with gh release upload, using GH_TOKEN and TAG from the existing release-please output. The step uploads the built archives without updating release metadata; triggers, job permissions and all other steps are unchanged.

Validation: five static checks and eight isolated mock cases passed, covering all six archive targets, prerelease tags and upload-error propagation. Independent source review found no blocker. No live asset upload or full build suite was run; release execution is skipped on PRs and needs owner-run release verification.

The requested --clobber behavior replaces same-name assets non-atomically. Merge and the subsequent release remain owner-controlled.

@rabesss-dot
rabesss-dot Bot requested a review from rabesss as a code owner October 19, 2026 17:31
@factory-droid

factory-droid Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Droid finished @rabesss-dot[bot]'s task —— View job


LGTM. The release upload change matches the requested fix, and no actionable correctness or security issues were found.

0 inline comments posted

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • gh release upload replaces softprops/action-gh-release in build-release: the Upload Release Asset step (.github/workflows/release.yml:148) now uploads dist/* to the release-please tag via gh release upload "$TAG" dist/* --clobber --repo "$GITHUB_REPOSITORY" with GH_TOKEN/TAG env. Since gh release upload only POSTs assets and never PATCHes the release, it sidesteps the update-a-release operation that GITHUB_TOKEN refused in the v0.1.32 run.

  • Directive fidelity: matches #283 verbatim — exact command string, env names, preserved step name, untouched contents: write job permissions, and a single-file scope with everything outside the step unchanged.

  • Verified: the six matrix legs build uniquely named archives (impartus_<version>_<goos>_<goarch>), so concurrent uploads can't collide and --clobber only matters on re-runs; gh is preinstalled on ubuntu-latest and already used by dispatch-release-package in this file; dropping the draft/prerelease inputs is inert because release-please owns release metadata; go test -run 'TestPackageImageVars|TestPackagesWorkflow|TestReleaseWorkflow' . passes (the release-workflow guard test doesn't constrain this step).

Pullfrog  | View workflow run | Using glm-5.3 | 𝕏

@rabesss-dot
rabesss-dot Bot merged commit 3127f4d into main Oct 19, 2026
24 checks passed
@rabesss-dot
rabesss-dot Bot deleted the dot/release-upload-283 branch October 19, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ci): release binaries fail to upload (v0.1.32)

0 participants