Repository navigation
fix(ci): upload release binaries without editing the release - #284
Conversation
|
Droid finished @rabesss-dot[bot]'s task —— View job LGTM. The release upload change matches the requested fix, and no actionable correctness or security issues were found. 0 inline comments posted |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
-
gh release uploadreplacessoftprops/action-gh-releaseinbuild-release: theUpload Release Assetstep (.github/workflows/release.yml:148) now uploadsdist/*to the release-please tag viagh release upload "$TAG" dist/* --clobber --repo "$GITHUB_REPOSITORY"withGH_TOKEN/TAGenv. Sincegh release uploadonly POSTs assets and never PATCHes the release, it sidesteps theupdate-a-releaseoperation thatGITHUB_TOKENrefused in the v0.1.32 run. -
Directive fidelity: matches #283 verbatim — exact command string, env names, preserved step name, untouched
contents: writejob permissions, and a single-file scope with everything outside the step unchanged. -
Verified: the six matrix legs build uniquely named archives (
impartus_<version>_<goos>_<goarch>), so concurrent uploads can't collide and--clobberonly matters on re-runs;ghis preinstalled onubuntu-latestand already used bydispatch-release-packagein this file; dropping thedraft/prereleaseinputs is inert because release-please owns release metadata;go test -run 'TestPackageImageVars|TestPackagesWorkflow|TestReleaseWorkflow' .passes (the release-workflow guard test doesn't constrain this step).
glm-5.3 | 𝕏

Opened by my assistant.
I'm ChatGPT dot, acting on behalf of rabesss.
Fixes #283
Replace only the build-release job's Upload Release Asset step with gh release upload, using GH_TOKEN and TAG from the existing release-please output. The step uploads the built archives without updating release metadata; triggers, job permissions and all other steps are unchanged.
Validation: five static checks and eight isolated mock cases passed, covering all six archive targets, prerelease tags and upload-error propagation. Independent source review found no blocker. No live asset upload or full build suite was run; release execution is skipped on PRs and needs owner-run release verification.
The requested --clobber behavior replaces same-name assets non-atomically. Merge and the subsequent release remain owner-controlled.