refactor: config early engine foundation - #2871
Open
nikolaevx wants to merge 9 commits into
Open
Conversation
Contributor
Benchmark for e83ce98Click to view benchmark
|
Contributor
Benchmark for 552f920Click to view benchmark
|
nikolaevx
force-pushed
the
config-early-engine-foundation
branch
from
July 8, 2026 15:51
2f41693 to
e4028c9
Compare
Contributor
Benchmark for 7f83793Click to view benchmark
|
Contributor
Benchmark for aad5891Click to view benchmark
|
Contributor
Benchmark for 955f270Click to view benchmark
|
Collaborator
Author
|
@copilot rebase |
Contributor
Done — merged latest |
Contributor
Benchmark for a2a6694Click to view benchmark
|
Contributor
Benchmark for 2fc9657Click to view benchmark
|
Collaborator
Author
|
@copilot rebase |
Collaborator
|
@gvozdvmozgu Can you give me a bit of an overview/plan for this work and what it unblocks? Sorry it's taken me a while to get to it. |
Collaborator
Author
|
This is part of a larger PR that ultimately improves the linter interface for external structures and aims to remove fragile pub fn render_file(&self, fname: String) -> RenderedFile {
let in_str = std::fs::read_to_string(&fname).unwrap();
match self.render_string(&in_str, fname.clone(), &self.config) {
Ok(rendered) => rendered,
Err(err) => {
log::error!("Failed to template file {}: {:?}", fname, err);
let source_str = Self::normalise_newlines(&in_str).to_string();
RenderedFile {
templated_file: TemplatedFile::new(
source_str.clone(),
fname.clone(),
None,Here and inside render_string. There are a lot of various changes. This was done a long time ago and involves many aspects; I've mostly been splitting it up over the last month. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing