fix: scope postgres array suffix spacing - #2780
Open
mtibben wants to merge 1 commit into
Open
Conversation
mtibben
marked this pull request as ready for review
June 23, 2026 00:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL array datatype suffixes should keep their type-suffix shape without changing square-bracket spacing for array literals in other dialects.
Postgres supports datatype suffixes like
TEXT[]andinteger[3][3], but treating the raw[token globally as touch-before also changes array literals such asSELECT [1, 2, 3] AS arrin dialects where the leading space is expected. This introduces a Postgres-specificarray_type_suffixsegment so layout can keep datatype suffixes tight while leaving general square-bracket spacing alone.This keeps the spacing behavior focused on the Postgres datatype construct and adds regression coverage for BigQuery, SparkSQL, and DuckDB array literals.