fix(path): resolve short wikilinks to folder notes - #5
Open
alastairsounds wants to merge 1 commit into
Open
alastairsounds wants to merge 1 commit into
alastairsounds wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slugifyFilePathrewritesFoo/Foo.mdto the slugFoo/index. The last path segment is thenindex, so theshorteststrategy intransformLinknever matches a short[[Foo]]link. The link resolves to a root-relative path that does not exist. No error occurs.transformLinknow retries against the folder name. The retry runs only under two conditions:If a real file has that name then the first pass matches it and the retry does not run.
These conditions are necessary. A version without them changed links that already resolved. If a vault holds both
Archive/Note.mdandFolder/Note/Note.md, a short[[Note]]link keepsArchive/Noteas its target.Tests
Two cases in
test/path.test.ts:resolves a folder note by its folder namefails without the change.prefers a real file over a folder note of the same namepasses with the change and without it. This case makes sure that a real file keeps priority.All 107 tests pass. The typecheck, eslint, prettier, and vitest gates in
npm run checkgive no error.Resolves #4