Remove the link to 'gmock' and 'gtest' from boilerplate.cmake#85
Open
benoitdudu wants to merge 1 commit into
Open
Remove the link to 'gmock' and 'gtest' from boilerplate.cmake#85benoitdudu wants to merge 1 commit into
benoitdudu wants to merge 1 commit into
Conversation
…d creating unnecessary dependencies for non-test targets. Add the missing link to 'gmock' and 'gtest' for the tests requiring it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Currently the link to 'gmock' and 'gtest' is done in boilerplate.cmake (and in several tests cmake files).
I would like to remove this link from boilerplate.cmake as it create unnecessary dependencies for others .so files (for example if you do a
ldd uart-pl011.soyou will see the dependency).Best Regards,
Benoît