Fix RoPE scaling factor propagation in Genie config - #340
Open
Ricardo Alves de Souza (ricardoasouz) wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ricardo Alves de Souza <ricardoasouz@hotmail.com>
Ricardo Alves de Souza (ricardoasouz)
force-pushed
the
dev/ricardoasouz/propagate-rope-scaling-factor
branch
from
August 27, 2026 00:13
fc2db59 to
d72108c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagate the model-provided RoPE scaling factor into the generated Genie config instead of always hardcoding
8.0.This preserves the existing fallback behavior when
factoris absent while allowing models such as Llama 3.2 to emit their configured value, such as32.0.This addresses the Genie config RoPE scaling factor propagation reported in #337. It does not attempt to address the separate v68 compile/runtime degeneration described in that issue.
Changes
Replace the hardcoded Genie RoPE scaling factor:
8.0rope_scaling.get("factor", 8.0)Preserve backward compatibility by keeping
8.0as the fallback whenfactoris not provided.Add a regression test verifying that the configured RoPE scaling factor is preserved in the generated Genie config.
Test Plan
Ran the targeted regression test:
Additional validation:
passed.
Pre-commit results:
The full-repository
mypyhooks run successfully but report existing type-checking errors in unrelated files across the repository. No reportedmypyerrors are in the files changed by this PR.Related to #337.