Feat/add qubit serialization to graphs - #164
Merged
Merged
Conversation
Elad-Zaharan
commented
Dec 31, 2025
| self._machine_metadata = None | ||
|
|
||
| # Only return metadata if machine exists and has qubits attribute | ||
| if not hasattr(self._machine, "qubits"): |
Collaborator
Author
There was a problem hiding this comment.
check this necessity
Collaborator
Author
There was a problem hiding this comment.
we check it in previous method so seems not necessary in case we dont mind that user change his machine after the previous method
Collaborator
Author
There was a problem hiding this comment.
what it does is, if we dont have the right attributes in machine, return None instead of {}, so in the eend we dont have metadata underqubits, we can either remove it or remain, depends on what we decide
Collaborator
Author
There was a problem hiding this comment.
we can move it into the previous method and in that edge case return None but not a must
Collaborator
Author
There was a problem hiding this comment.
for now, i removed it
natangqm
approved these changes
Jan 1, 2026
natangqm
approved these changes
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.