wirer: prefer MW-FEM readout analog port pairings (out1+in2, out8+in1) - #344
Open
KevinAVR wants to merge 2 commits into
Open
wirer: prefer MW-FEM readout analog port pairings (out1+in2, out8+in1)#344KevinAVR wants to merge 2 commits into
KevinAVR wants to merge 2 commits into
Conversation
For INPUT_AND_OUTPUT wiring specs, try MW-FEM out1+in2 then out8+in1 before the generic MW-FEM spec. Output-only allocations are unchanged. Update existing wirer tests and add coverage for the new defaults. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@TheoLaudatQM @deanpoulos this PR intention is to default the MW-FEM readout wiring to be AO1-AI2 and AO8-AI1 based on our qua-docs recommendation. |
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@deanpoulos and @OziEgri now tests are passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INPUT_AND_OUTPUT(readout), try MW-FEM analog out1 + in2, then out8 + in1, before the unconstrained MW-FEM allocation path.Test plan
python -m pytest tests/wirer/ -vMade with Cursor