Repository navigation
build(deps): bump jdx/mise-action from 5.2.0 to 5.2.3 - #59
Merged
Merged
Conversation
Owner
|
@dependabot rebase |
Owner
|
@dependabot recreate |
Bumps [jdx/mise-action](https://github.com/jdx/mise-action) from 5.2.0 to 5.2.3. - [Release notes](https://github.com/jdx/mise-action/releases) - [Changelog](https://github.com/jdx/mise-action/blob/main/CHANGELOG.md) - [Commits](jdx/mise-action@9b200bc...82a612c) --- updated-dependencies: - dependency-name: jdx/mise-action dependency-version: 5.2.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/github_actions/jdx/mise-action-5.2.2
branch
from
October 31, 2026 07:21
682ea15 to
80d1889
Compare
qawatake
approved these changes
Oct 31, 2026
qawatake
left a comment
Owner
There was a problem hiding this comment.
Update review: jdx/mise-action 5.2.0 → 5.2.3
Final decision: Proceed (実施)
Risk: Low — all axes low: patch-level action update, workflow-only, mise and tool versions are pinned so CI/release toolchain does not drift; supply chain checked (see below)
Review type: Approve
Release/deploy: Not needed (no-release) — workflow-only change (.github/workflows/*); no build input changes. This repo has no release workflow.
Changes reviewed (2.1)
- Note: after
@dependabot recreate(the rebase request was not acted on) this PR was regenerated from 5.2.2 to 5.2.3, so the review covers 5.2.3. - Primary sources: release notes v5.2.1, v5.2.2, v5.2.3; compare v5.2.0...v5.2.2 (
action.yml,src/index.ts,dist/index.jsgrep; upstream research for 5.2.2 reused, basis: tag commit8418fedbverified earlier) and compare v5.2.2...v5.2.3 read for this review (5 commits: renovate chores,fix(cache): hash mise config files without walking the workspace (#703), release commit;src/config-hash.ts/src/index.tspatches read: path/glob logic only, no new network access or command execution). The SHA pinned in this PR,82a612c5ab8bcda7cc5db6b7e81a8e7584c3dc6e, equals the upstream v5.2.3 tag commit (lightweight tag, contained in main, commit verified). - Version range: 5.2.0 → 5.2.1 → 5.2.2 → 5.2.3.
- Behavior changes: 5.2.1 — for mise ≥ 2026.9.3 a missing
packslip.sigstore.jsonis now a hard error (no downgrade to minisign); 5.2.2 — cache key also hashesconf.d/*.tomlfragments; 5.2.3 — config files for the cache key are looked up only in the working dir and its parents (no more walkingnode_modules), cache keys change once (one cache miss after upgrade). No change to inputs' defaults, outputs, permissions or node runtime (node24).
Impact and adequacy (2.2, 2.3)
| Change | Affected / not affected | Basis | PR handling adequate? |
|---|---|---|---|
| packslip mandatory for mise ≥ 2026.9.3 | Not affected | every jdx/mise-action step pins version: 2026.8.3 (git grep -A3 jdx/mise-action .github) |
Yes |
| cache key computation (5.2.2/5.2.3) | One cache miss only | the repo has only a root mise.toml (no conf.d, .config/mise/, .tool-versions, sub-project configs), so the hashed set is the same file; versions come from the pinned mise and mise.toml, not from the cache |
Yes |
| tool versions across 30-day cache rotation (introduced in 5.2.0, already on main) | Known constraint | mise.toml pins pnpm 10.34.7 but node only as "24", so node 24.x minor can change when the cache rotates; unchanged by this PR |
n/a (pre-existing) |
| all uses updated | Yes | all 3 jdx/mise-action uses in ci.yml now point to 82a612c5… (diff against current main) |
Yes |
Verification (2.4)
- CI on the recreated head 80d1889 (base = current main 31e7bec, after the electron fix #58):
build,e2e,test-e2e-toolspassed (run 41180285787). node scripts/check-actions-pinned.mjspasses in CI (all actions SHA-pinned).- This PR's own CI runs the new action (the
ci.ymljobs use it), so mise install/cache with v5.2.2 is exercised directly.
Rollback, supply chain, license (2.5, 2.6, 2.7)
- Rollback: revert the commit; no side effects (cache entries are just re-created).
- Supply chain: release by
github-actions[bot]via release-plz (same as previous releases), immutable releases, tag commits signed/verified (jdx), contained in main; v5.2.3 published 2026-10-24 (7 days), v5.2.2 10 days.dist/grows with the bundledpackslip/sigstore-js (introduced in 5.2.0, already on main). - License: MIT → MIT (same LICENSE blob).
Block conditions
- Hit: none.
Requests
- None.
Unverified / notes for reviewers (2.9)
dist/index.jswas not rebuilt from source to confirm reproducibility (upstream release workflow commits the bundle).- Merge order: workflow-only PRs do not touch the lockfile; landed after the electron security fix so CI could run past the
pnpm auditstep.
dependabot
Bot
deleted the
dependabot/github_actions/jdx/mise-action-5.2.2
branch
October 31, 2026 07:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps jdx/mise-action from 5.2.0 to 5.2.3.
Release notes
Sourced from jdx/mise-action's releases.
Changelog
Sourced from jdx/mise-action's changelog.
... (truncated)
Commits
82a612cchore: release v5.2.3 (#704)2d0418bchore(deps): update dependency hk to latest (#705)e891ddechore(deps): update jdx/mise-action action to v5.2.0 (#706)91e7f82fix(cache): hash mise config files without walking the workspace (#703)9a35c22chore(deps): update github actions (#701)8418fedchore: release v5.2.2 (#699)bb33e9bchore(deps): update communique, hk in mise.lock (#700)0cc9f84fix: hash conf.d config fragments in cache key (#698)7ce9a02chore(deps): lock file maintenance (#697)fc42bccchore: release v5.2.1 (#696)