Repository navigation
build(deps): bump jdx/mise-action from 5.1.1 to 5.2.0 - #55
Conversation
Bumps [jdx/mise-action](https://github.com/jdx/mise-action) from 5.1.1 to 5.2.0. - [Release notes](https://github.com/jdx/mise-action/releases) - [Changelog](https://github.com/jdx/mise-action/blob/main/CHANGELOG.md) - [Commits](jdx/mise-action@2d8d4ca...9b200bc) --- updated-dependencies: - dependency-name: jdx/mise-action dependency-version: 5.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
qawatake
left a comment
There was a problem hiding this comment.
Update review: jdx/mise-action 5.1.1 → 5.2.0
Reviewed head: eb9ce4138f8924d5c3750c6021766ebb32181625 (base ead3a5b452eff22dbf8588833336a14c9caaf25e)
Final verdict: Proceed
Risk: Medium — axes hit: change type (minor release with a documented default change: the cache key format). The other axes are low: CI-only tool, no external input, rollback is reverting the pin, the changed behaviour is exercised by this PR's own CI run, supply chain checks pass, license unchanged.
Review type: Approve
Release/deploy: Not needed (no-release) — reason: this repository is a sample / reference setup for Obsidian plugin e2e testing and ships no artifact: there are no GitHub releases or tags, main.js is gitignored ("They should be uploaded to GitHub releases instead" but no release workflow exists), and nothing is published to npm. The only thing readers consume is the repository content itself, which this merge updates directly. The change is workflow-only (.github/workflows/ci.yml), so there is nothing to build and compare. I add no-release so the PR does not read as "undecided".
Changes reviewed (2.1)
- Primary sources read: release notes for v5.1.2 and v5.2.0, CHANGELOG.md, compare v5.1.1...v5.2.0 (29 commits), the action.yml diff and the dist/package.json diff.
- Version range covered: 5.1.1 → 5.1.2 → 5.2.0.
- Breaking / behavior changes: (1) the default cache key gains a 30-day period suffix
-p<N>and a new inputcache_max_age_days(#689): one cache miss after the upgrade, then a rebuild every 30 days. (2) New inputmonorepo(default true): addsmise install --monorepoonly when the mise config has[monorepo].config_roots(#679). (3) PATH export now followsmise env --pathsorder (#685). (4) The mise binary is verified against the release's signed packslip via sigstore; no fallback on verification failure (#693). (5) Latest-version lookup falls back from GitHub to mise.jdx.dev (#692). (6) v5.1.2:mise_dirnow exportsMISE_DATA_DIR; Windowsauto_updateno longer crashes on EPERM. Inputs were only added, none removed or renamed; runtime stays node24; no new permissions.dist/index.jsgrows by ~47k lines because the new runtime dependencypackslip@1.8.0(same owner, jdx) and sigstore are bundled.
Impact and adequacy of the PR (2.2, 2.3)
| Change | Affected location / none | Evidence | PR handling adequate? |
|---|---|---|---|
| Cache key format | All 3 jdx/mise-action steps in ci.yml (build, e2e, test-e2e-tools) use cache: true without cache_key |
grep cache_key in .github/workflows: no hits |
Yes. Seen in this head's CI: mise cache not found for mise-v1-linux-x64-ubuntu24-2026.8.3-p691-… / …macos-arm64-macos26-…-p691-…, then the cache is saved. One-off miss, nothing to configure |
| mise version drift through the cache rebuild | None | Every step pins version: 2026.8.3; check-toolchain.mjs → toolchain: ok (pnpm 10.33.2, node 24) |
Yes |
monorepo |
None | grep [monorepo] / config_roots in mise.toml: no hits |
Yes |
| PATH export order | mise-managed tools are node 24 and pnpm only | No rustup / cargo or other preinstalled-tool overlap (grep in workflows: none) |
Yes |
| packslip (sigstore) verification | The mise download in every job | Log on ubuntu and macOS: Verified mise-v2026.8.3-linux-x64.tar.zst against signed checksums / …macos-arm64… |
Yes |
| Fallback to mise.jdx.dev | None: a pinned version fetches from GitHub only; hosted runners without an egress allowlist |
— | Yes |
mise_dir / MISE_DATA_DIR |
None | grep `mise_dir | MISE_DATA_DIR` in workflows: no hits |
| SHA pin | 9b200bcecbfd6303e69a4a261b2e09e3757440a7 is the commit of the lightweight tag v5.2.0; the # v5.2.0 comment matches in all 3 places |
tag dereference; CI check-actions-pinned.mjs passed |
Yes |
Verification (2.4)
- CI on this head (https://github.com/qawatake/obsidian-e2e-sample/actions/runs/40000584521):
buildpassed (frozen install, toolchain / actions-pinned / config-schema checks,pnpm audit"No known vulnerabilities found", lint, typecheck, build, bundled-deps check),e2epassed on macOS (e2e:setup"1 passed",e2e:test"1 passed"),test-e2e-toolspassed (e2e:setupande2e:cleanup, "1 passed" each). I read the logs: mise-action v5.2.0 ran in all three jobs with the behaviours listed above (cache miss on the new-p691key, packslip verification). - Base moved since this CI ran:
mainis noweea83f1(#57).git log ead3a5b..origin/main --statshows exactly one commit touchingmise.tomlandpackage.json(pnpm 10.33.2 → 10.34.7, 2 insertions / 2 deletions), no workflow file. GitHub reports the merge state as CLEAN, so the review was done against this head as-is. main's owncirun oneea83f1(https://github.com/qawatake/obsidian-e2e-sample/actions/runs/40065247461) fails atpnpm audit --audit-level=highwith two advisories published on 2026-10-23 after this PR's CI: GHSA-jr5w-w6x2-84p9 (electron < 43.8.1) and GHSA-xjj6-f33q-929c (undici < 7.30.1, viaelectron > @electron/get). That failure is pre-existing and independent of this PR; the post-mergecirun will show it too until the lockfile PRs (#56 / #58) land.
Rollback, supply chain, license (2.5, 2.6, 2.7)
- Rollback: revert the pin. No persistent side effect beyond an extra cache entry.
- Supply chain: tag v5.2.0 → commit
9b200bce, a GPG-verifiedchore: release v5.2.0 (#680)by jdx (owner), contained in main. Release created bygithub-actions[bot]through the same release workflow as v5.1.1. Published 2026-10-16 (8 days ago). No maintainer change. The new runtime dependencypackslip@1.8.0is published by jdx's own npm account with provenance. Binary verification is strengthened (sigstore identityjdx/miserelease.yml). Known gap: v5.2.0 silently falls back to minisign verification when the packslip is missing (closed in v5.2.1); minisign verification is what v5.1.1 did, so this is not a regression. - License: MIT → MIT (LICENSE blob identical). Newly bundled transitive packages are MIT / ISC / Apache-2.0 / BSD-2-Clause / BlueOak-1.0.0, all permissive.
Blocking conditions
- Hit: none.
Requests
- None for the PR author. This PR touches only
ci.yml; #56 and #58 touch onlypackage.json/pnpm-lock.yaml, so there is no file overlap in this repository.
Unverified / notes for other reviewers (2.9)
- Reproducibility of
dist/index.jsfromsrc/was not verified. - The sigstore verification path was observed only as the log line; the TUF root fetch was not inspected.
- v5.2.1 / v5.2.2 exist (v5.2.1 closes the fallback gap above). Dependabot's 7-day cooldown will offer them later.
Bumps jdx/mise-action from 5.1.1 to 5.2.0.
Release notes
Sourced from jdx/mise-action's releases.
... (truncated)
Changelog
Sourced from jdx/mise-action's changelog.
... (truncated)
Commits
9b200bcchore: release v5.2.0 (#680)b511e8dChange minimum age for auto-merging release PRs887d1f4docs: use resolved Windows downloads cache path (#690)93c62adchore: replace prettier with oxfmt (#694)04716d4feat: verify the mise binary against its signed packslip (#693)5108104feat(cache): retry throttled cache restores and saves (#692)d401260docs: explain caching mise downloads instead of installs (#686)e7cf35ffeat(cache): rebuild the cache every 30 days by default (#689)cd02696fix: export the PATH entries mise reports with mise env --paths (#685)6784481docs: tell release workflows not to use the cache (#682)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)