Repository navigation
build(deps): bump jdx/mise-action from 5.0.1 to 5.1.1 - #51
Merged
Merged
Conversation
Bumps [jdx/mise-action](https://github.com/jdx/mise-action) from 5.0.1 to 5.1.1. - [Release notes](https://github.com/jdx/mise-action/releases) - [Changelog](https://github.com/jdx/mise-action/blob/main/CHANGELOG.md) - [Commits](jdx/mise-action@7a4e45a...2d8d4ca) --- updated-dependencies: - dependency-name: jdx/mise-action dependency-version: 5.1.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
qawatake
approved these changes
Oct 17, 2026
qawatake
left a comment
Owner
There was a problem hiding this comment.
Update review: jdx/mise-action v5.0.1 → v5.1.1
Final decision: Proceed
Risk assessment: Medium — axes hit: change type (minor; v5.1.1 documents a breaking change in default behavior, which does not apply to this repo). All other axes Low.
Review type: Approve
Release/deploy: Not required (no-release) — rationale: the PR only changes .github/workflows/ci.yml. The shipped artifact of this plugin is main.js + manifest.json, built locally by pnpm build and attached to GitHub releases; no workflow in this repo builds or publishes it. A CI action is not on the bundled / emitted / generated path, so the artifact bytes cannot change.
Changes reviewed (2.1)
- Primary sources consulted: release notes of v5.1.0 and v5.1.1; compare v5.0.1...v5.1.1 (16 commits, file list incl.
action.yml,src/,dist/index.js). - Version range reviewed: v5.0.1 → v5.1.0 → v5.1.1 (all intermediate releases).
- Breaking / behavior changes:
- v5.1.1 (documented as breaking):
github_tokenis no longer exported to later steps asMISE_GITHUB_TOKEN; newpersist_github_tokeninput (defaultfalse). - v5.1.0: cached mise is kept when
versionis unset (auto_updateinput, defaultfalse); cache is saved after a partial-match restore; newversions/ per-tool step outputs; newpluginsandcache_save_postinputs;action.ymlnow declares apost:step (only saves cache whencache_save_post: true); warning whenmise_tomlinput is shadowed by.mise.toml.
- v5.1.1 (documented as breaking):
Impact and adequacy of the PR (2.2, 2.3)
| Change | Affected location / no impact | Evidence | Is the PR adequate |
|---|---|---|---|
MISE_GITHUB_TOKEN no longer persisted |
No impact | Searched scripts/, .github/, package.json, mise.toml, tests/ for MISE_, GITHUB_TOKEN, GH_TOKEN, mise exec/run/x: the only later steps needing a token (scripts/setup-obsidian.sh → gh) get GH_TOKEN explicitly in ci.yml. All tools are installed by install: true, so no lazy install needs the token. CI logs on this head show persist_github_token: false, no Setting MISE_GITHUB_TOKEN, and every later step passing. |
Yes (no change needed; this is a hardening for this repo) |
Cache behavior when version unset / auto_update |
No impact | ci.yml pins version: 2026.8.3; release notes state an explicit version behaves as before. Log: Verified existing mise-v2026.8.3 ... against signed checksums, cache key unchanged (mise-v1-...-2026.8.3-3981b3d...). |
Yes |
| Partial-match cache save fix | No impact (exact cache hit in all 3 jobs) | Job logs: Cache hit for: mise-v1-... |
Yes |
New post: step, cache_save_post |
No functional impact | Input defaults to false (log shows cache_save_post: false); post step completed without errors. |
Yes |
New outputs / plugins input / mise_toml warning |
Not used | ci.yml uses only version, install, cache. |
Yes |
Verification (2.4)
- CI results, and what CI does not cover: run 38944573389 on head
632836c—build,e2e,test-e2e-toolsall success. Every job uses the changed action, so the change is exercised directly by CI. Not covered: a cold-cache run (all three jobs restored the cache); the install path itself is unchanged for an explicitversion. - Additional checks I did: read the job log bodies (not just the status) for
buildande2e: mise 2026.8.3 verified against signed checksums, node 24.19.0 / pnpm 10.33.2 resolved as before,check-toolchain/check-actions-pinned/check-config-schemaallok, e2e1 passed.
Rollback, supply chain, license (2.5, 2.6, 2.7)
- Rollback: revert the SHA pin in
ci.yml. No irreversible side effects (cache keys unchanged). - Supply chain: tag
v5.1.1→ commit2d8d4cafcbd33be2ea37d2b6f5ad595363d1f1ca(lightweight tag, matches the pin in this PR); the commit is an ancestor ofmain(compare: behind 30, ahead 0). Release published 2026-10-04 bygithub-actions[bot]and marked immutable, same as v5.0.1. All commits in range authored by the maintainer (jdx) via PRs. Upstream checks on the release commit includeCheck dist/(dist rebuilt from source and diffed) andzizmor, all success. Published 13 days ago; issues opened in jdx/mise-action since 2026-10-04 (#657, #664, #668, #669, #688, #691) contain no compromise report and none concern the inputs used here (version,install,cache). - License: MIT → MIT (unchanged).
Blocking conditions
- Hit: none.
Requests
- None.
Unverified items / notes for other reviewers (2.9)
- Cold-cache behavior with v5.1.x was not exercised (all jobs hit the cache). Known constraint, not a blocker: the download / checksum path for an explicit
versionis documented as unchanged, and a failure would surface as a red CI run, not a silent change. - I did not read
dist/index.jsline by line; I relied on upstream'sCheck dist/job for dist ↔ source consistency.
dependabot
Bot
deleted the
dependabot/github_actions/jdx/mise-action-5.1.1
branch
October 17, 2026 03:11
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps jdx/mise-action from 5.0.1 to 5.1.1.
Release notes
Sourced from jdx/mise-action's releases.
... (truncated)
Changelog
Sourced from jdx/mise-action's changelog.
... (truncated)
Commits
2d8d4cachore: release v5.1.1 (#659)3eb43e3fix: make GitHub token persistence opt-in (#658)94c60b3chore: release v5.1.0 (#640)4fff0c6feat: add plugins input (#656)893fc72docs: add matrix and external cache guides; warn on shadowed mise_toml (#654)41f5868feat: add opt-in cache_save_post input (#649)2fe229bfix: cache mise binary for caches saved without a version record (#648)abd75d9fix: extract mise zip with PowerShell instead of unzip on Windows (#650)4b9c295docs: explain the Rust cache caveat and workarounds (#651)7927c6ffeat: output active tool versions (#655)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)