Repository navigation
build(deps-dev): bump the npm-minor-patch group with 3 updates - #49
Merged
qawatake merged 2 commits intoOct 9, 2026
Merged
Conversation
Bumps the npm-minor-patch group with 3 updates: [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome), [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) and [electron](https://github.com/electron/electron). Updates `@biomejs/biome` from 2.5.14 to 2.5.15 - [Release notes](https://github.com/biomejs/biome/releases) - [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md) - [Commits](https://github.com/biomejs/biome/commits/@biomejs/biome@2.5.15/packages/@biomejs/biome) Updates `@types/node` from 24.19.0 to 24.19.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `electron` from 43.7.5 to 43.7.7 - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v43.7.5...v43.7.7) --- updated-dependencies: - dependency-name: "@biomejs/biome" dependency-version: 2.5.15 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: "@types/node" dependency-version: 24.19.1 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: electron dependency-version: 43.7.7 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Owner
|
Biome 2.5.15でmigrateを実行し、$schema以外の変更が不要なことを確認したため、schema URLのみ追随しました(2.3/2.4、事前合意済み定型修正)。 |
qawatake
reviewed
Oct 9, 2026
qawatake
left a comment
Owner
There was a problem hiding this comment.
アップデートレビュー: Biome 2.5.14 → 2.5.15 / Node型 24.19.0 → 24.19.1 / Electron 43.7.5 → 43.7.7
最終判定: 実施
リスク評価: 中 — ネイティブのテスト用ランタイムを更新するが、配布物にはElectronを含めず、実Obsidianで検証済み。
レビュー種別: Comment(所有者本人のためApprove相当の判定を記録)
確認した変更点 (2.1)
- 一次情報: Biome 2.5.15、Electron 43.7.6、43.7.7、公式npm tarball・metadata、@types/node。
- Biome: nurseryルール追加、Svelte/HTML/Astro等のparser・formatter・lintの誤検出修正、設定エラー保持、型推論・性能修正。新ルールの自動有効化はなし。対象versionのmigrationでschema以外の変更なしを確認済み。
- Node型: 24.19.0と24.19.1の公式tarball比較ではzlib ZstdOptions.pledgedSrcSizeの追加とpackage/README metadataのみ。ランタイム変更なし。
- Electron: 43.7.6のLinux/Wayland/X11・focus・dialogs・native API・終了・clipboard・zoom・WebAssembly等の修正と、43.7.7のANGLE/Chromium/Dawn/V8 backportを確認。テスト用ElectronのAPI削除や要求major変更なし。
- 推移的依存: undici 7.29.1のTLS/WebSocket/cache/decompression/retryのsecurity修正と7.30.0のbackpressure/HTTP2/diagnostics修正を公式リリースまで確認。Sass使用repoは1.105.0→1.105.1のmedia-query間@extendのエラー表示修正も確認。
影響範囲と対応の妥当性 (2.2, 2.3)
| 変更点 | 影響箇所 / 影響なし | 根拠 | PRの対応は妥当か |
|---|---|---|---|
| Biome設定とlint修正 | biome.jsoncと既存lint対象 | schemaだけ追随しmigration無差分・lint無修正 | 妥当 |
| Node型 | 既存TypeScriptの型検査 | 新headのtsc --noEmit成功。zlib変更の利用なし | 妥当 |
| Electron | tests/support・tests/e2e(-setup)の起動・UI・終了 | esbuildでelectronはexternal。変更固有のfocus/dialog/終了経路を実Obsidian/macOS E2Eで確認 | 妥当 |
| Sass(該当repoのみ) | 開発ビルドのCSS | 正常ビルドとCSS namespace検査、preview幅/scroll E2E成功。エラー表示改善のため正常CSS変更は不要 | 妥当 |
| undici | Electron取得用のHTTP処理 | 実binary取得とObsidianセットアップ成功。主要アプリの独自TLS/HTTP2/cache interceptor利用なし | 妥当 |
検証 (2.4)
- 新headの全CI成功: frozen install、toolchain/action pin/schema、既存audit gate、lint、型検査、build、配布物の依存確認、該当するCSS scope検査。
- macOS上で実ObsidianとElectron 43.7.7の一致をログで確認しE2E成功。sampleはvault setup/cleanupも成功、core/cardは各6 tests(hotkey、preview scroll/幅、cardはIMEを含む)成功。
- previewに限定される追加事象なし。配布物でElectronを差し替えず、実アプリE2Eが今回の起動・focus・終了・描画経路を確認する。
切り戻し・供給元・ライセンス (2.5, 2.6, 2.7)
- PRのsquash commitをrevertし旧package/lock/schemaへ戻す。データ形式・DB migrationなし。main CI/E2Eを監視し回帰があればrelease前に止めて戻す。
- 正規npm名・公式repo・公開者の継続を確認、npm integrityとlock一致。Biome 9/30、Node型10/1、Electron 9/30、Sass9/29の公開で既存7日制限を満たす。新たなinstall lifecycle script追加なし。Electron binary取得経路は既存の公式release。
- Biome MIT OR Apache-2.0、Node型/Electron/Sass MIT、undici MITを維持。
ブロック条件
- 該当なし。
依頼事項
- なし。
未確認・レビュアーへの申し送り (2.9)
- 既知の制約: auditにmoderate 1件。Obsidian型定義がmoment 2.29.4をexact pinするため、GHSA-4p3w-j4w9-5jqwの更新jobは解決不能。公式advisoryはserver npmのmoment.locale()へ攻撃者由来の非stringを渡す場合のpath traversal。対象の全src/tests/main検索でmoment利用は0件、npm型定義側の依存であり、このPRで危険な実行経路を追加しない。型定義供給元のpin解消は別途通知・提案し、minor overrideは自動追加していない。
dependabot
Bot
deleted the
dependabot/npm_and_yarn/npm-minor-patch-4ae1d5a660
branch
October 9, 2026 22:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the npm-minor-patch group with 3 updates: @biomejs/biome, @types/node and electron.
Updates
@biomejs/biomefrom 2.5.14 to 2.5.15Release notes
Sourced from @biomejs/biome's releases.
... (truncated)
Changelog
Sourced from @biomejs/biome's changelog.
... (truncated)
Commits
0b4c11fci: release (#11815)ad5b362feat: addsnoAstroConflictingSetDirectivesrule for .astro (#11494)034366dchore: update codspeed logo in readme (#12019)717db8cfeat(lint): add noMisplacedListElements (#11917)089bde0feat(lint/js): add useStrictBooleanExpressions (#11750)1fdb5c2feat(lint/js/svelte): add useSvelteKitRuneImports lint rule (#11960)faa8b37feat(lint/js/svelte): add noSvelteExportLet (#11956)b2b4400chore: update sponsors (#11973)ff4c4ddfeat(lint/js): add noMeaninglessVoidOperator (#11732)1b9479efeat(lint): add useLogicalProperties rule (#10816)Updates
@types/nodefrom 24.19.0 to 24.19.1Commits
Updates
electronfrom 43.7.5 to 43.7.7Release notes
Sourced from electron's releases.
Commits
ddb762fchore: cherry-pick 26 changes from angle, chromium, dawn and v8 (#54569)661853drefactor: remove electron::ScopedHString in favor of base::win::ScopedHString...bd9e012test: run pointer lock permission spec serially (#54581)8cf09e9test: wait for PageState sync before navigating in restore spec (#54575)b18bcf4test: run fullscreen specs serially (#54577)37e9cfatest: parse all custom page size PDFs in one pdf.js process (#54542)fb950f4test: wait for child output before asserting on it (#54543)c2831edtest: wait for focus before requesting pointer lock in spec (#54534)babbd10test: wait for earlier Electron workers to exit before serial specs (#54510)e1777defix: apply the X11 input shape before setIgnoreMouseEvents() returns (#54498)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions