Skip to content

Fix Voxtral Metal streaming mask#19695

Open
JacobSzwejbka wants to merge 1 commit into
mainfrom
fix-metal-voxtral-mask
Open

Fix Voxtral Metal streaming mask#19695
JacobSzwejbka wants to merge 1 commit into
mainfrom
fix-metal-voxtral-mask

Conversation

@JacobSzwejbka
Copy link
Copy Markdown
Contributor

This changes Voxtral Realtime streaming Metal additive masks to use a finite large negative value instead of -inf, matching the existing offline Metal mask behavior. The failing Metal AOTI Voxtral CI run completed inference but generated no printable transcript after the PyTorch 2.12 bump; using a finite mask avoids MPS SDPA/AOTI propagating bad values from -inf masked positions.

Test plan:
PYTHONPATH=src python -m pytest examples/models/voxtral_realtime/tests/test_ring_kv_cache.py -q

This PR was authored with Claude.

@JacobSzwejbka JacobSzwejbka requested a review from lucylq as a code owner May 20, 2026 14:08
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 20, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19695

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Cancelled Job, 2 Unrelated Failures, 1 Unclassified Failure

As of commit dd8bf36 with merge base 7724fd7 (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

  • Check Labels / Check labels (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    RuntimeError: GraphQL query

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/metal CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant