Allow passes to operate on unlifted graph modules (#19674)#19674
Allow passes to operate on unlifted graph modules (#19674)#19674DrJessop wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19674
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit 383e934 with merge base 3d86cc7 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105637321. |
This PR needs a
|
Summary: EdgeProgramManager.transform assumed that we were applying passes to graph modules which couldn't modify constants. Added functionality to transform to lower constants into the graph module before running passes, and then lift them back at the end. So far, this is done by opting in to minimize the surface area of tests that would be affected by this, but could eventually become the default. Reviewed By: ethansfng Differential Revision: D105637321
ade289c to
383e934
Compare
Summary:
EdgeProgramManager.transform assumed that we were applying passes to graph modules which couldn't modify constants. Added functionality to transform to lower constants into the graph module before running passes, and then lift them back at the end. So far, this is done by opting in to minimize the surface area of tests that would be affected by this, but could eventually become the default.
Reviewed By: ethansfng
Differential Revision: D105637321