exir: Prevent implicit symbolic ProxyValue conversion#19661
Open
oscarandersson8218 wants to merge 1 commit into
Open
exir: Prevent implicit symbolic ProxyValue conversion#19661oscarandersson8218 wants to merge 1 commit into
oscarandersson8218 wants to merge 1 commit into
Conversation
Stop pass code from silently turning symbolic ProxyValues into Python values through bool, int, float, or index conversion. Add regressions for bool, int, float, and index cases using symbolic metadata from an exported dynamic graph. Change-Id: Ib1bf5c771ddba0e219264541e5b39811db0c2fe2 Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
oscarandersson8218
requested review from
JacobSzwejbka and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19661
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit f5c2ded with merge base acf1ad9 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop pass code from silently turning symbolic ProxyValues into Python values through bool, int, float, or index conversion as this can lead to graph breakage.
Add regressions for bool, int, float, and index cases using symbolic metadata from an exported dynamic graph.
cc @digantdesai @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell @rascani