Rename ARM FP8 inline helpers to NEON naming conventions#426
Merged
Conversation
Rename cpuinfo_has_arm_f8dot and cpuinfo_has_arm_f8mm to cpuinfo_has_arm_neon_f8dot4 and cpuinfo_has_arm_neon_f8mm. ARM type support refers to scalar ARM, not NEON. FP8 scalar conversions are checked via cpuinfo_has_arm_fp8, while the dot product and matrix multiplication instructions are NEON/SIMD. Details: - Add backward compatibility macros: #define cpuinfo_has_arm_f8dot cpuinfo_has_arm_neon_f8dot4 #define cpuinfo_has_arm_f8mm cpuinfo_has_arm_neon_f8mm - Rename inline helpers to cpuinfo_has_arm_neon_f8dot4 and cpuinfo_has_arm_neon_f8mm - Update callers in tools/isa-info.c - Add test coverage in test/mock/pixel-8.cc Fixes pytorch#427
JakeStevens
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
cpuinfo_has_arm_f8dotandcpuinfo_has_arm_f8mmtocpuinfo_has_arm_neon_f8dot4andcpuinfo_has_arm_neon_f8mm.ARM type support refers to scalar ARM, not NEON. FP8 scalar conversions are checked via
cpuinfo_has_arm_fp8, while the dot product and matrix multiplication instructions are NEON/SIMD.Details:
#define cpuinfo_has_arm_f8dot cpuinfo_has_arm_neon_f8dot4#define cpuinfo_has_arm_f8mm cpuinfo_has_arm_neon_f8mmcpuinfo_has_arm_neon_f8dot4andcpuinfo_has_arm_neon_f8mmtools/isa-info.ctest/mock/pixel-8.ccFixes #427