Repository navigation
Fix typing for _fill_device() methods - #393
Merged
Merged
Conversation
Member
Author
|
It seems that there is a problem in the tango backend ? |
Member
Author
Member
Closed
2 tasks
Member
It's the same problem that I fixed in this PR https://github.com/python-accelerator-middle-layer/tango-pyaml/pull/37/changes? |
Member
|
Yes, I think so. I think I had exactly that error. |
gupichon
approved these changes
Sep 10, 2026
Member
|
I'll adjust the pipeline to prevent this from happening again. |
Member
Author
|
Nice the fix 37 from @TeresiaOlsson works flawlessly. |
Member
Well... I also caused the bug to start with ;) |
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR fix typing for
_fill_device()methods and also add a super method inElementto inform developers who may forget to implement it. It also allow better code introspection.