Avoid PytestAssertRewriteWarning in tests using runpytest#1508
Draft
pctablet505 wants to merge 1 commit into
Draft
Avoid PytestAssertRewriteWarning in tests using runpytest#1508pctablet505 wants to merge 1 commit into
pctablet505 wants to merge 1 commit into
Conversation
Adds --assert=plain to inner runpytest calls for tests that check warning counts, and removes redundant pytest_plugins declarations in generated test code. Keeps in-process execution so the pytest-dev#1227 FreeBSD fix remains effective. Fixes pytest-dev#1334
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1334
Pass
--assert=plainto the in-processrunpytestcalls for the six tests that emitPytestAssertRewriteWarning, keeping the #1227 in-process fix intact. Also drop the explicitpytest_pluginsassignment in the two event-loop fixture tests so they do not mark the already-loaded plugin for assertion rewriting.