Fix complete groupby - #1700
Open
SumanGouda wants to merge 7 commits into
Open
Conversation
…ict fill_value bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1700 +/- ##
==========================================
- Coverage 87.56% 85.99% -1.58%
==========================================
Files 95 125 +30
Lines 6819 9965 +3146
==========================================
+ Hits 5971 8569 +2598
- Misses 848 1396 +548 🚀 New features to boost your workflow:
|
samukweku
reviewed
Aug 30, 2026
samukweku
left a comment
Collaborator
There was a problem hiding this comment.
adorn.py should not be in this pr, same goes for the GitHub template.md file
samukweku
requested changes
Aug 30, 2026
samukweku
left a comment
Collaborator
There was a problem hiding this comment.
Kindly rebase your pr and keep out unrelated code/files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
getattr(df, "obj", df).columnsin_computations_completeto safely inspect column names without raisingAttributeErrorwhendfis aDataFrameGroupByobject.fill_valueexist in the target DataFrame.col in fill_value) during dictionary construction to preventKeyErrorcrashes when passing partialfill_valuedictionaries.df = df.objunpacking until afterdf.expand()executes.This PR resolves #1669.
PR Checklist
Please ensure that you have done the following:
CHANGELOG.mdunder the latest version header describing the contribution.Relevant Reviewers
Please tag maintainers to review.