Skip to content

refactor: remove obsolete length argument from reverse aggregation calls #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samukweku wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

refactor: remove obsolete length argument from reverse aggregation calls #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5cb7e5
refactor: remove obsolete length argument from reverse aggregation calls
samukweku Aug 28, 2026
9c0997f
fix: support old reverse aggregation wheels
samukweku Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## [Unreleased]
- [ENH] Drop the unused `length` argument from every `conditional_join` reverse-aggregation call into `janitor_rs` (`starts`, `ends`, `*_matches`, `*_starts_ends_matches`, `positions`, `no_range`, and `size`'s equivalents) - it was only ever forwarded to the Rust boundary, which already derives its own bound and never used the caller-supplied value. Requires a janitor-rs build with the matching Rust-side removal. - Issue #1698 @samukweku
- [PERF] Reduce peak memory in `_build_indexer_reorder_contents` for wide frames (reps >= 8) using single NumPy allocation; tall frames with few repetitions retain the original reshape path. - Issue #1655 @Anupam2400
- [ENH] `conditional_join` now picks the most selective `<`/`<=`/`>`/`>=` predicate as its binary-search anchor (instead of the first one supplied) when `keep` is `'first'` or `'last'`, fixing pathological slowdowns from unfavorable predicate ordering; the choice is estimated from a fixed-size sample so the selection cost no longer scales with input size; `keep='all'` output is unaffected. - Issue #1641 @samukweku
- [BUG] Fix `conditional_join` crash for `keep='last'` joins with a single `<`/`<=` window and multiple non-equi conditions - a missing `counts` argument to the Rust `index_starts_only_keep_last` call. - Issue #1641 @samukweku
Expand Down
Loading
Loading