[ENH]: fix adorn functions to preserve numeric values in first column (#1676) - #1696
Open
SumanGouda wants to merge 4 commits into
Open
[ENH]: fix adorn functions to preserve numeric values in first column (#1676)#1696SumanGouda wants to merge 4 commits into
SumanGouda wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1696 +/- ##
==========================================
- Coverage 87.56% 85.98% -1.58%
==========================================
Files 95 125 +30
Lines 6819 9962 +3143
==========================================
+ Hits 5971 8566 +2595
- Misses 848 1396 +548 🚀 New features to boost your workflow:
|
SumanGouda
force-pushed
the
fix/adorn-numeric-first-column
branch
from
August 26, 2026 18:03
63cf8c8 to
c00cf7a
Compare
Author
|
The doc build failed with a 403 permission error on github-actions[bot] deploying to gh-pages (PR preview deployment from fork). |
Collaborator
|
@ericmjl may i get your review on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ENH]: fix adorn functions to preserve numeric values in first column
PR Description
Please describe the changes proposed in the pull request:
adorn_pct_formatting,adorn_ns, andadorn_roundingto exclude the first column (index 0) from numeric column processing so non-category identifiers (e.g.,cyl) remain untouched.adorn_nssafely handles data column types by casting targeted columns toobject.test_adorn_functions_preserve_numeric_first_columnintests/functions/test_tabyl.pyto verify behavior with numeric first columns.This PR resolves #1676.
PR Checklist
Please ensure that you have done the following:
sumangouda:dev, but rather fromsumangouda:fix/adorn-numeric-first-column.CHANGELOG.mdunder the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.