perf: coordinate reverse positions aggregation APIs - #1690
Open
samukweku wants to merge 3 commits into
Open
Conversation
Remove a duplicate _sum_starts_ends definition, replace ~87 repeated per-call dtype-dispatch dicts in _agg_functions.py/_compare.py/ _binary_search.py with one cached dispatcher (_rs_func), and swap repeat_index calls for np.repeat, which benchmarks faster at every scale tested and is more immediately readable. Issue #1649 @samukweku Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V3KAbkp6JV96KYXNc6EJmN
Collaborator
Author
|
Contract documentation is now included in this PR and its branch
An ELI5 explanation is included in the Python module docstring and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coordinate the pyjanitor calls for all five reverse positions aggregations. Remove the redundant
lengthargument from the positions wrappers and dispatch only the remaining positions aggregations with that argument.Related
Verification
Runtime tests and benchmark execution remain pending because the local macOS host lacks the configured Python 3.9 framework.