perf: update reverse ends aggregation boundary - #1686
Open
samukweku wants to merge 3 commits into
Open
Conversation
Contributor
|
Collaborator
Author
|
Contract documentation is now included in this PR and its branch
An ELI5 explanation is included in the Python module docstring and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the pyjanitor side of janitor-rs issue #94.
Updates reverse ends+matches aggregation dispatch for the length-free Rust API and includes a narrow fallback for older installed janitor_rs releases that still require length. The ordinary reverse ends path keeps its existing length argument.
Tests: pixi run pytest tests/functions/test_conditional_join.py -k agg_rev -q (20 passed).
Benchmark: the corresponding Rust PRs compare old maps vs compact slots across tiny, large, very large, and super large duplicate/unique workloads; results are documented on janitor-rs issue #94.