Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,17 @@ CLI.
include MkDocs. The documentation task is available in the `docs` environment.
**Recommendation**: Run `pixi run -e docs build-docs` to build documentation.

### [2026-08-26] Include performance evidence in optimization PRs and issues

**Context**: Performance changes are coordinated with implementation changes
in janitor-rs.
**Learning**: Benchmark results are part of the performance change's review
record, not merely local investigation notes.
**Recommendation**: Every performance PR and its tracking issue must include a
properly formatted comparison with the old implementation, covering runtime
and memory for the agreed tiny, large, very-large, and super-large cases and
duplicate/unique label distributions. State benchmark limitations explicitly.

---

## Version History
Expand Down
2 changes: 0 additions & 2 deletions janitor/functions/_conditional_join/_agg_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -1356,7 +1356,6 @@ def _min_rev_starts_matches(
index: np.ndarray,
matches: np.ndarray,
booleans: np.ndarray,
length: int,
) -> tuple:
"""
Compute min
Expand Down Expand Up @@ -1385,7 +1384,6 @@ def _min_rev_starts_matches(
index=index,
matches=matches,
booleans=booleans,
length=length,
)


Expand Down
6 changes: 4 additions & 2 deletions janitor/functions/_conditional_join/_get_join_aggs.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,15 +180,17 @@ def _agg_join_left(df: pd.DataFrame, aggfunc: list, indices: dict) -> pd.DataFra
booleans = pd.isna(arr)
arr = _helpers._convert_array_to_numpy(array=arr)
func = mapping[agg]
_index, out = func(
kwargs = dict(
arr=arr,
starts=indices["starts"],
index=indices["right_index"],
matches=indices["matches"],
counts=indices["counts_array"],
booleans=booleans,
length=indices["right_index"].size,
)
if agg != "min":
kwargs["length"] = indices["right_index"].size
_index, out = func(**kwargs)
if agg in {
"sum",
"prod",
Expand Down
Loading