Propagate overlay directory listing errors - #749
Open
smigolsmigol wants to merge 1 commit into
Open
Conversation
Return host listing failures from overlay iterdir instead of presenting unreadable directories as empty. Extend the existing direct/overlay permission matrix with directory enumeration.
Merging this PR will not alter performance
Comparing Footnotes
|
smigolsmigol
marked this pull request as ready for review
August 14, 2026 21:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlay
iterdirreturned an empty list when the host directory listing failed.Direct mounts return the mapped error, so permission, not-found, not-a-directory, and entry iteration failures could appear as an empty directory only in overlay mode.
Propagate the error returned by
host_list_visible_dir_entry_names.The helper's existing symlink filtering and memory accounting remain unchanged.
The existing direct and overlay permission parity test now covers
Iterdir.Tests
cargo test -p monty-fs overlay_permission_errors_match_direct_modecargo test -p monty-fsmake format-rsmake lint-rsSummary by cubic
Propagates host directory listing errors from overlay iterdir to match direct mounts. Previously overlay returned an empty list on host listing failure; now it returns the mapped error (permission, not-found, not-a-directory, iteration).
overlay_permission_errors_match_direct_modetest to cover iterdir.Written for commit ee50785. Summary will update on new commits.