Fix OverflowError for a large 32-bit usize - #746
Merged
davidhewitt merged 3 commits intoAug 17, 2026
Conversation
Two issues would cause crashes (traps) in wasm (needs a 32-bit build): - `collections.deque([], 2**40)` - `bytes(2**40)` Raise an OverflowError error pre-emptively instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Merging this PR will not alter performance
Comparing Footnotes
|
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
davidhewitt
approved these changes
Aug 17, 2026
davidhewitt
enabled auto-merge (squash)
August 17, 2026 10:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues would cause crashes (traps) in wasm (needs a 32-bit build):
collections.deque([], 2**40)bytes(2**40)Raise an OverflowError error pre-emptively instead.
Summary by cubic
Fixes 32-bit wasm traps by raising OverflowError when size-like ints exceed
usize. Previouslydeque([], 2**40)andbytes(2**40)crashed; now they raise CPython-matching messages. 64-bit behavior is unchanged.crates/monty-js/__test__/wasm_word_size.spec.tsto assert exceptions and session survival in@pydantic/monty/wasm(skipped in browser).bytes: makeusize::try_fromfallible and map errors toOverflowErrorviaoverflow_index_sized_int.deque: makemaxlenconversion fallible and map errors toOverflowErrorviaoverflow_c_ssize_tto match CPython wording.overflow_repeat_counttooverflow_index_sized_int; update callers inlong_int.rs.bytesedge cases; pool architecture limitations wording updated.Written for commit a1d3eda. Summary will update on new commits.