Repository navigation
Conversation
Fstarnb
force-pushed
the
fix/5876-analytic-heat-of-mixing
branch
from
October 13, 2026 21:56
88d80a0 to
30b6499
Compare
Fstarnb
force-pushed
the
fix/5876-analytic-heat-of-mixing
branch
from
October 14, 2026 05:03
30b6499 to
562a9d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5876
When heat of mixing is enabled, quadratic and quartic particle profiles reconstruct concentration from average and surface states. Applying the finite-volume gradient to those expressions uses incompatible radial discretizations and raises a ShapeError during model build.
Use the symbolic radial derivative when the concentration expression contains a spherical spatial variable. Keep the existing grad/inner calculation for Fickian profiles, which have no explicit radial variable.
This complements #5769: that PR adds phase summation, effective diffusivity, and the zero heat shortcut for uniform profiles. Its phase heat expression still applies grad(c), so the polynomial-profile build failure remains.
Validation