Repository navigation
test: attach meshes with with_mesh() in the unstructured plotting tests - #5796
Merged
Merged
Conversation
MarcBerliner
approved these changes
Sep 25, 2026
BradyPlanden
enabled auto-merge (squash)
September 25, 2026 15:55
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5796 +/- ##
==========================================
- Coverage 98.20% 98.00% -0.21%
==========================================
Files 345 346 +1
Lines 34857 35259 +402
==========================================
+ Hits 34232 34554 +322
- Misses 625 705 +80 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#5690's unstructured plotting tests attach a mesh by setting
.meshon a symbol. #5779 made symbols immutable, so onmain27 tests intest_plot_vtk.pyandtest_unstructured_plot_grid.pyfail on every platform:This builds those symbols with
with_mesh()instead. It changes only tests. The same commit is in #5785, where CI caught it.Type of change
Tests only, so no CHANGELOG entry.
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests