FileNotFoundError caught - #157
Closed
leninnair wants to merge 1 commit into
Closed
Conversation
Current line182 in __init__.py ( f = importlib.resources.files('pyfiglet.fonts').joinpath(font).open('rb')) was causing FileNotFoundError when the function isValidFont() was called with an invalid file name. It has been caught. Also, documentation added. Test case also added.
Owner
|
Thanks for contributing. Someone sent another attempt in #161 which is slightly better prepared, so I'm likely to go with that implementation for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current line182 in init.py ( f = importlib.resources.files('pyfiglet.fonts').joinpath(font).open('rb')) was causing FileNotFoundError when the function isValidFont() was called with an invalid file name. It has been caught. Also, documentation added. Test case also added.