puppet-lint fixes

[pearsondavid]

tidy manifests to comply with puppet-lint

[CLAassistant]

All committers have signed the CLA.

[LukasAud]

Hi @pearsondavid, I had to start a rebase to kick off testing. Not sure if the PR has been affected by recent updates or puppet-lint changes but your suggested changes do not pass our puppet-lint automated tests. It looks like the PR could have lost its purpose as time passed.

For now, I'll close it. Feel free to re-open if you think this still fixes a valid problem.

[pearsondavid]

Thanks @LukasAud

Looking a the latest code from v9.1.0, the issue hasn't been fixed in instance_service.pp and program.pp has similar issues now as well. Shall I re-open this and/or create a new one?

./types/programs.pp - ERROR: there should be a single newline at the end of a manifest on line 9 (check: manifest_whitespace_double_newline_end_of_file)
./manifests/program.pp - WARNING: indent should be 6 chars and is 8 on line 44 (check: strict_indent)
./manifests/program.pp - WARNING: indent should be 6 chars and is 8 on line 45 (check: strict_indent)
./manifests/program.pp - WARNING: indent should be 6 chars and is 8 on line 46 (check: strict_indent)
./manifests/program.pp - WARNING: indent should be 6 chars and is 8 on line 47 (check: strict_indent)
./manifests/program.pp - WARNING: indent should be 6 chars and is 8 on line 48 (check: strict_indent)
./manifests/instance_service.pp - WARNING: indent should be 4 chars and is 6 on line 50 (check: strict_indent)
./manifests/instance_service.pp - WARNING: indent should be 4 chars and is 6 on line 55 (check: strict_indent)
./manifests/instance_service.pp - WARNING: indent should be 4 chars and is 6 on line 56 (check: strict_indent)
./manifests/instance_service.pp - WARNING: indent should be 4 chars and is 6 on line 57 (check: strict_indent)
./manifests/instance_service.pp - WARNING: indent should be 4 chars and is 6 on line 58 (check: strict_indent)