Deprecate ports parameter as a string - #611
Open
traylenator wants to merge 1 commit into
Open
Conversation
traylenator
force-pushed
the
breakingports
branch
from
May 22, 2024 15:16
a9d92b3 to
5d0f8b8
Compare
kenyon
approved these changes
May 26, 2024
|
Hi @traylenator, there seems to be some conflicts with the PR. If you could resolve those, I'll be happy to kick of testing and get this moving. |
Previously it was possible to set the ports parameter as: * `'1234'` * `'1234,5678'` * `['1234']` * `['1234','5678']` Since puppetlabs#610 the ports parameter could also be specified with `Stdlib::Ports`: * `1234` * `[1234]` * `[1234, 5678]` With this patch all the previous string values are deprecated and will fail. The `Stdlib::Port` values must be used.
traylenator
force-pushed
the
breakingports
branch
from
July 30, 2026 13:12
5d0f8b8 to
69e2d28
Compare
LukasAud
reviewed
Aug 3, 2026
| }, | ||
| String $instance = 'haproxy', | ||
| String[1] $section_name = $name, | ||
| Optional[Boolean] $sort_options_alphabetic = undef, |
There was a problem hiding this comment.
It looks like the PR contains a regression for a previous PR (#573). Could you adjust this?
LukasAud
reviewed
Aug 3, 2026
| }, | ||
| String $instance = 'haproxy', | ||
| String[1] $section_name = $name, | ||
| Optional[Boolean] $sort_options_alphabetic = undef, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously it was possible to set the ports parameter as:
'1234''1234,5678'['1234']['1234','5678']Since #610 the ports parameter could also be specified with
Stdlib::Ports:1234[1234][1234, 5678]With this patch all the previous string values are deprecated and will fail. The
Stdlib::Portvalues must be used.Checklist
puppet apply)