Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the todo in the ServerConfigurations class by adding automatic retrieval of per-world paper config files (and filtering them not to overwhelm the flare ui when the config is empty) and adds back the paper regular configs. It also addresses an Airplane issue where this class might have not retrieved all configs properly had their path been changed using the startup arguments.
Also added a flag argument for specifying a custom pufferfish config file and removes an useless dependency (its brought through the api module)
This implementation was taken from Pufferfork and has been tested on a live flare server instance.
this impl also caches the configs for subsequent flare runs not to waste time on unnecessary IO