Deduplicate channels and groups in request building

lib/pubnub/events/heartbeat.rb

@@ -25,7 +25,7 @@ def path
         'sub-key',
         @subscribe_key,
         'channel',
-        Formatter.channels_for_url(@channel),
+        Formatter.channels_for_url(@channel.uniq),
         'heartbeat'
       ].join('/')
     end
@@ -37,7 +37,7 @@ def parameters(*_args)
         parameters.delete(:state) if parameters[:state] == '%7B%7D'
       end
       parameters[:heartbeat] = @heartbeat
-      parameters['channel-group'] = @group.join(',') unless @group.blank?
+      parameters['channel-group'] = @group.uniq.join(',') unless @group.blank?
       parameters
     end
 

lib/pubnub/subscribe_event.rb

@@ -124,7 +124,7 @@ def path
         'v2',
         'subscribe',
         @subscribe_key,
-        Pubnub::Formatter.channels_for_url(@channel + @wildcard_channel),
+        Pubnub::Formatter.channels_for_url((@channel + @wildcard_channel).uniq),
         0
       ].join('/').gsub(/\?/, '%3F')
     end
@@ -151,7 +151,7 @@ def add_timetoken_to_params(params)
     end
 
     def add_group_to_params(params)
-      params['channel-group'] = @group.join(',') unless @group.empty?
+      params['channel-group'] = @group.uniq.join(',') unless @group.empty?
       params
     end
 

spec/lib/events/heartbeat_spec.rb

@@ -42,6 +42,19 @@
       end
     end
 
+    it "sends unique channels and channel groups even when duplicates are provided" do
+      VCR.use_cassette("lib/events/heartbeat-unique", record: :once) do
+        envelope = @pubnub.heartbeat(
+          channel: ['demo', 'demo', 'demo-b'],
+          channel_group: ['grp-a', 'grp-a'],
+        ).value
+
+        expect(envelope.status[:client_request].to_s).to include('/channel/demo,demo-b/')
+        expect(envelope.status[:client_request].to_s).to include('channel-group=grp-a')
+        expect(envelope.status[:client_request].to_s).not_to include('channel-group=grp-a,grp-a')
+      end
+    end
+
     it "forms valid ErrorEnvelope on error" do
       VCR.use_cassette("lib/events/heartbeat-error", record: :once) do
         envelope = @pubnub.heartbeat(