Add Docker option to toggle IPv6 - #335
Open
KiwifruitDev wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to disable IPv6 through Pterodactyl's
config.ymland fixes pterodactyl/panel#5488.Issue
On Linux kernels with IPv6 disabled (such as through grub using
ipv6.disable=0inGRUB_CMDLINE_LINUX_DEFAULT), there is a fatal issue when Wings creates thepterodactyl0network interface:Which also causes this error in each Pterodactyl server's console under this node:
Solution
With this change, the issue can be solved by setting
docker.network.interfaces.v6.enabledtofalsein/etc/pterodactyl/config.yml:Documentation
For existing users upgrading to a new version containing this change, the
pterodactyl0network interface would already exist on the system. If a user decides to disable IPv6, Docker's network cache would need to be cleared first:Then on next time they run Wings, the network interface will be created with IPv6 disabled.
These steps would need to be added to the Pterodactyl documentation.
Regression testing
By default, the
Enabledoption is set totrueand the previous behavior which caused the issue would continue to happen as before. Existing users would not be affected.