refactor(subscriptions): extract user-managed SQL package - #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move trigger-based subscriptions out of daemon-owned migrations into an optional SQL package under
extensions/subscriptions. Subscription objects now live inpgstream_subscriptionsand are installed by the application migration role, so the pgstream runtime no longer needs ownership of subscribed tables.Breaking Upgrade
Existing installations must run
extensions/subscriptions/upgrades/from-pgstream-0.1.sqlbefore starting this version. The upgrade moves rows and functions withALTER ... SET SCHEMA, preserving subscription UUIDs, generated function OIDs, and target-trigger dependencies; the core migration blocks non-empty legacy installations with an actionable hint.User-Managed Lifecycle
The package includes fresh-install, upgrade, and uninstall SQL while retaining the existing drop-and-recreate trigger behavior.
set_subscriptions()remains an optional example that users can copy and customize rather than part of the default installation.Integration coverage verifies restricted runtime privileges, fresh installation, optional reconciliation, legacy upgrade preservation, uninstall cleanup, and existing subscription event behavior across the updated test suite.